Expose loki.porcess stages package for config conversions #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we go ahead with this approach, we should also move the |
tpaschalis
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
After an offline sync, I'm approving this so we don't have to break the convention of where conversion-related code exists for now.
Once this is done however, I'd like to reconsider moving stuff behind an internal package; let's add a TODO comment here so that we don't forget to do that.
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In order to implement promtail config conversions, we'll need to create
loki.processstages, which are currently internal package.We need to expose it in order to continue. As an alternative, we could write some conversion logic inside the
processpackage, but it may not be a desired way to organise code.