Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose loki.porcess stages package for config conversions #4369

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Expose loki.porcess stages package for config conversions #4369

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49f1614
Expose loki.porcess stages package for config conversions
thampiotr Jul 7, 2023
2a19517
reorder imports
thampiotr Jul 7, 2023
170c764
Export metrics too and add todo
thampiotr Jul 7, 2023
84868a7
improve todo
thampiotr Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve todo
  • Loading branch information
@thampiotr
thampiotr committed Jul 7, 2023
commit 84868a7e8e41c37ddbf5bbfe02dbff21a4943e69
6 changes: 4 additions & 2 deletions component/loki/process/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ import (
"github.com/grafana/agent/component/loki/process/stages"
)

// TODO: We should reconsider which parts of this component should be exported and which should
// be internal before 1.0, specifically the metrics and stages configuration structures.
// TODO(thampiotr): We should reconsider which parts of this component should be exported and which should
// be internal before 1.0, specifically the metrics and stages configuration structures.
// To keep the `stages` package internal, we may need to move the `converter` logic into
// the `component/loki/process` package.

func init() {
component.Register(component.Registration{
Expand Down