Clarification and fixing typos in discovery.kubernetes.md #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
changed the title
thampiotr
commented
Jul 19, 2023
Comment on lines
293
to
296
| The endpoints role supports pod, service and endpoints selectors. | ||
| The pod role supports node selectors when configured with `attach_metadata: {node: true}`. | ||
| Other roles only support selectors matching the role itself (e.g. node role can only contain node selectors). | ||
|
|
There was a problem hiding this comment.
spartan0x117
approved these changes
Jul 19, 2023
Co-authored-by: Mischa Thompson <mischabear@gmail.com>
|
No rush with this one @clayton-cornell - feel free to merge it when you get to review it :) |
clayton-cornell
approved these changes
Jul 20, 2023
clayton-cornell
added
type/docs
grafanabot
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com> (cherry picked from commit 76fee88)
grafanabot
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com> (cherry picked from commit 76fee88)
grafanabot
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com> (cherry picked from commit 76fee88)
clayton-cornell
pushed a commit
that referenced
this pull request
Jul 20, 2023
) * Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com> (cherry picked from commit 76fee88) Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
clayton-cornell
pushed a commit
that referenced
this pull request
Jul 20, 2023
) * Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com> (cherry picked from commit 76fee88) Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
clayton-cornell
pushed a commit
that referenced
this pull request
Jul 20, 2023
) * Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com> (cherry picked from commit 76fee88) Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com>
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Fix typos in discovery.kubernetes.md * Update discovery.kubernetes.md * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
We've received a question regarding the selectors/role attribute - why wouldn't it always match the top-level role attribute.
Turns out there is a use case for this as documented in prometheus docs - porting this explanation to our docs with this PR.
Also fixes some typos and a broken link.