Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification and fixing typos in discovery.kubernetes.md #4509

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Clarification and fixing typos in discovery.kubernetes.md #4509

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
221ad6e
Fix typos in discovery.kubernetes.md
thampiotr Jul 19, 2023
313dbfb
Update discovery.kubernetes.md
thampiotr Jul 19, 2023
7738904
Update docs/sources/flow/reference/components/discovery.kubernetes.md
thampiotr Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/sources/flow/reference/components/discovery.kubernetes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,10 @@ Name | Type | Description | Default | Required
See Kubernetes' documentation for [Field selectors][] and [Labels and
selectors][] to learn more about the possible filters that can be used.

The endpoints role supports pod, service, and endpoints selectors.
The pod role supports node selectors when configured with `attach_metadata: {node: true}`.
Other roles only support selectors matching the role itself (e.g. node role can only contain node selectors).

> **Note**: Using multiple `discovery.kubernetes` components with different
> selectors may result in a bigger load against the Kubernetes API.
>
Expand All @@ -299,7 +303,7 @@ selectors][] to learn more about the possible filters that can be used.
> instead.

[Field selectors]: https://kubernetes.io/docs/concepts/overview/working-with-objects/field-selectors/
[Labels and selectros]: https://Kubernetes.io/docs/concepts/overview/working-with-objects/labels/
[Labels and selectors]: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
[discovery.relabel]: {{< relref "./discovery.relabel.md" >}}

### attach_metadata block
Expand Down