refactor!: refactor how we do defaults for runtime overrides #12448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean
commented
Apr 3, 2024
pkg/loki/loki.go
Outdated
| Tracing tracing.Config `yaml:"tracing"` | ||
| Analytics analytics.Config `yaml:"analytics"` | ||
| RuntimeConfig runtimeconfig.Config `yaml:"runtime_config,omitempty"` | ||
| OperationConfig runtime.Config `yaml:"operation_config,omitempty"` |
There was a problem hiding this comment.
struggling a bit with the name here.....
DylanGuedes
requested changes
Apr 3, 2024
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
it's only a breaking change for us right now, I don't believe we ever released code with that default section in the runtime config? that didn't make it into 2.9 I don't think? Update: this did make it into 2.9 |
Signed-off-by: Edward Welch <edward.welch@grafana.com>
DylanGuedes
requested changes
Apr 3, 2024
Signed-off-by: Edward Welch <edward.welch@grafana.com>
DylanGuedes
approved these changes
Apr 3, 2024
slim-bean
changed the title
Signed-off-by: Edward Welch <edward.welch@grafana.com>
github-actions
bot
added
the
type/docs
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
JStickler
reviewed
Apr 3, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
slim-bean
changed the title
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…#12448) Signed-off-by: Edward Welch <edward.welch@grafana.com> Co-authored-by: Dylan Guedes <djmgguedes@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We introduced a "defaults" section into the runtime overrides for runtime configs, however this prevented us from being able to set a default for these values without providing a runtime config.
we already have a pattern for this we used for limits_config so this PR refactors those defaults to be a first class object in the loki config and follows the same pattern of setting this as defaults.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR