Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: refactor how we do defaults for runtime overrides #12448

Merged
merged 13 commits into from
Apr 3, 2024
Merged

refactor!: refactor how we do defaults for runtime overrides #12448

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
876bc20
refactor how we do defaults for runtime overrides
slim-bean Apr 3, 2024
e63e9ac
Update pkg/runtime/config.go
slim-bean Apr 3, 2024
c3251e3
remove from jsonnet
slim-bean Apr 3, 2024
a3c04fb
remove from jsonnet part 2
slim-bean Apr 3, 2024
a4b4076
update docs and changelog
slim-bean Apr 3, 2024
93730d0
update root block docs
slim-bean Apr 3, 2024
d85002d
forgot to make doc
slim-bean Apr 3, 2024
5e2a029
forgot to update type
slim-bean Apr 3, 2024
348119f
Update docs/sources/configure/_index.md
slim-bean Apr 3, 2024
03f086e
Update docs/sources/setup/upgrade/_index.md
slim-bean Apr 3, 2024
9404d88
Update docs/sources/setup/upgrade/_index.md
slim-bean Apr 3, 2024
b876cea
fix docs
slim-bean Apr 3, 2024
7123050
fix tests
slim-bean Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pkg/runtime/config.go 
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
  • Loading branch information
@slim-bean @DylanGuedes
slim-bean and DylanGuedes committed Apr 3, 2024
commit e63e9ac89902d3bc378dd642dfcdb370ccd0d109
2 changes: 1 addition & 1 deletion pkg/runtime/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type Config struct {
func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
f.BoolVar(&cfg.LogStreamCreation, "operation-config.log-stream-creation", false, "Log every new stream created by a push request (very verbose, recommend to enable via runtime config only).")
f.BoolVar(&cfg.LogPushRequest, "operation-config.log-push-request", false, "Log every push request (very verbose, recommend to enable via runtime config only).")
f.BoolVar(&cfg.LogPushRequestStreams, "operation-config.log-push-request-streams", false, "Log every stream in a pus request (very verbose, recommend to enable via runtime config only).")
f.BoolVar(&cfg.LogPushRequestStreams, "operation-config.log-push-request-streams", false, "Log every stream in a push request (very verbose, recommend to enable via runtime config only).")
f.BoolVar(&cfg.LimitedLogPushErrors, "operation-config.limited-log-push-errors", true, "Log push errors with a rate limited logger, will show client push errors without overly spamming logs.")
}

Expand Down
Loading