Extension point for returning different content types from API endpoints: expose QueryData so that implementations of Codec can use it. #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form a type assertion against Response.Data. Signed-off-by: Charles Korn <charles.korn@grafana.com>
|
Would be great to have these changes proposed in upstream Prometheus too. For example, exposing a struct like you did here should be non controversial. |
Yep, I've added it to prometheus/prometheus#11905. |
|
This is now ready for review. |
pracucci
approved these changes
Feb 3, 2023
pracucci
deleted the
mimir-prometheus-api-response-format-extension-point
branch
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Feb 3, 2023
pracucci
added a commit
to grafana/mimir
that referenced
this pull request
Feb 18, 2023
… requested + request format from query-frontend if enabled (#4153) * Add initial implementation of protobuf codec in querier. * Introduce flag to enable requesting new query result payload format from querier. * Add integration test for new query result payload format. * Extract JSON decoding to its own method. * Fix typo. * Rename test. * Always check for expected error in test. * Send appropriate Accept header based on configured query result payload format. * Extract JSON format to its own type, and fail if a query response contains an unknown content type. * Move JSON format tests to their own file. * Add TODO. * Implement protobuf format for decoding responses from querier in query-frontend. * Add changelog entry. * Use main branch of mimir-prometheus now that grafana/mimir-prometheus#427 has been merged. * Address PR feedback: use t.Fatalf() in test. * Address PR feedback: return pointer from DecodeResponse. * Address PR feedback: use `query-result-response-format` as flag name. Co-authored-by: Marco Pracucci <marco@pracucci.com> * Address PR feedback: clarify test names. Co-authored-by: Marco Pracucci <marco@pracucci.com> * Address PR feedback: fix test names. Co-authored-by: Marco Pracucci <marco@pracucci.com> * Address PR feedback: avoid confusion by specifying protobuf format as preferred format in test. * Address PR feedback: take preferred format as parameter rather than entire query middleware config. * Rename configuration option everywhere. * Address PR feedback: store preferred response format and use switch statement to set Accept header. * Address PR feedback: rename format to formatter. * Use new flag name in integration test. * Update docs. --------- Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #412 - ran into this issue while implementing the new protobuf codec in the querier.