-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go to 1.20.4 #4902
Update Go to 1.20.4 #4902
Conversation
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Probably need |
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Right. I was waiting for build-image build to finish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + tested local build of binary and Docker image
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-4902-to-release-2.8 origin/release-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x ad3cb5578281a2b0ab4cde716afca62b41ecab62
# Push it to GitHub
git push --set-upstream origin backport-4902-to-release-2.8
git switch main
# Remove the local backport branch
git branch -D backport-4902-to-release-2.8 Then, create a pull request where the |
@@ -14,6 +14,7 @@ | |||
* [ENHANCEMENT] Querier: reduce CPU utilisation when shuffle sharding is enabled with large shard sizes. #4851 | |||
* [ENHANCEMENT] Packaging: facilitate configuration management by instructing systemd to start mimir with a configuration file. #4810 | |||
* [ENHANCEMENT] Store-gateway: reduce memory allocations when looking up postings from cache. #4861 #4869 | |||
* [ENHANCEMENT] Go: update to 1.20.4. #4092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR number is wrong :)
* Update Go to 1.20.4. * CHANGELOG.md * Update build image. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit ad3cb55)
* Update Go to 1.20.4 (#4902) * Update Go to 1.20.4. * CHANGELOG.md * Update build image. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit ad3cb55) * Update changelog for go security update Signed-off-by: Jon Kartago Lamida <me@lamida.net> --------- Signed-off-by: Jon Kartago Lamida <me@lamida.net> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
What this PR does
This PR updates used Go version to 1.20.4.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]