Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.20.4 #4902

Merged
merged 3 commits into from
May 3, 2023
Merged

Update Go to 1.20.4 #4902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f4099f
Update Go to 1.20.4.
pstibrany May 3, 2023
d30e188
CHANGELOG.md
pstibrany May 3, 2023
b25e3a6
Update build image.
pstibrany May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/compare-helm-with-jsonnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: '1.20.3'
go-version: '1.20.4'
- uses: helm/kind-action@v1.2.0
- name: Download yq
uses: dsaltares/fetch-gh-release-asset@d9376dacd30fd38f49238586cd2e9295a8307f4c
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/helm-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
conftest:
runs-on: ubuntu-latest
container:
image: grafana/mimir-build-image:chore-upgrade-go-1203-5c4c29f01
image: grafana/mimir-build-image:update-go-to-1.20.4-3f4099fd0
steps:
- name: Check out repository
uses: actions/checkout@v3
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/test-build-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
lint:
runs-on: ubuntu-latest
container:
image: grafana/mimir-build-image:chore-upgrade-go-1203-5c4c29f01
image: grafana/mimir-build-image:update-go-to-1.20.4-3f4099fd0
steps:
- name: Check out repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
lint-jsonnet:
runs-on: ubuntu-latest
container:
image: grafana/mimir-build-image:chore-upgrade-go-1203-5c4c29f01
image: grafana/mimir-build-image:update-go-to-1.20.4-3f4099fd0
steps:
- name: Check out repository
uses: actions/checkout@v3
Expand All @@ -90,7 +90,7 @@ jobs:
lint-helm:
runs-on: ubuntu-latest
container:
image: grafana/mimir-build-image:chore-upgrade-go-1203-5c4c29f01
image: grafana/mimir-build-image:update-go-to-1.20.4-3f4099fd0
steps:
- name: Check out repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
test_group_id: [0, 1, 2, 3]
test_group_total: [4]
container:
image: grafana/mimir-build-image:chore-upgrade-go-1203-5c4c29f01
image: grafana/mimir-build-image:update-go-to-1.20.4-3f4099fd0
steps:
- name: Check out repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:
build:
runs-on: ubuntu-latest
container:
image: grafana/mimir-build-image:chore-upgrade-go-1203-5c4c29f01
image: grafana/mimir-build-image:update-go-to-1.20.4-3f4099fd0
steps:
- name: Check out repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -198,7 +198,7 @@ jobs:
- name: Upgrade golang
uses: actions/setup-go@v3
with:
go-version: 1.20.3
go-version: 1.20.4
- name: Check out repository
uses: actions/checkout@v3
- name: Run Git Config
Expand Down Expand Up @@ -244,7 +244,7 @@ jobs:
if: (startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/r') ) && github.event_name == 'push' && github.repository == 'grafana/mimir'
runs-on: ubuntu-latest
container:
image: grafana/mimir-build-image:chore-upgrade-go-1203-5c4c29f01
image: grafana/mimir-build-image:update-go-to-1.20.4-3f4099fd0
steps:
- name: Check out repository
uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* [ENHANCEMENT] Querier: reduce CPU utilisation when shuffle sharding is enabled with large shard sizes. #4851
* [ENHANCEMENT] Packaging: facilitate configuration management by instructing systemd to start mimir with a configuration file. #4810
* [ENHANCEMENT] Store-gateway: reduce memory allocations when looking up postings from cache. #4861 #4869
* [ENHANCEMENT] Go: update to 1.20.4. #4092
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR number is wrong :)

* [BUGFIX] Metadata API: Mimir will now return an empty object when no metadata is available, matching Prometheus. #4782
* [BUGFIX] Store-gateway: add collision detection on expanded postings and individual postings cache keys. #4770

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ mimir-build-image/$(UPTODATE): mimir-build-image/*
# All the boiler plate for building golang follows:
SUDO := $(shell docker info >/dev/null 2>&1 || echo "sudo -E")
BUILD_IN_CONTAINER ?= true
LATEST_BUILD_IMAGE_TAG ?= chore-upgrade-go-1203-5c4c29f01
LATEST_BUILD_IMAGE_TAG ?= update-go-to-1.20.4-3f4099fd0

# TTY is parameterized to allow Google Cloud Builder to run builds,
# as it currently disallows TTY devices. This value needs to be overridden
Expand Down
2 changes: 1 addition & 1 deletion development/mimir-microservices-mode/dev.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.20.3
FROM golang:1.20.4
ENV CGO_ENABLED=0
RUN go install github.com/go-delve/delve/cmd/dlv@v1.20.2

Expand Down
2 changes: 1 addition & 1 deletion development/mimir-read-write-mode/dev.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.20.3
FROM golang:1.20.4
ENV CGO_ENABLED=0
RUN go install github.com/go-delve/delve/cmd/dlv@v1.20.2

Expand Down
2 changes: 1 addition & 1 deletion mimir-build-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

FROM k8s.gcr.io/kustomize/kustomize:v4.5.5 as kustomize
FROM alpine/helm:3.11.1 as helm
FROM golang:1.20.3-bullseye
FROM golang:1.20.4-bullseye
ARG goproxyValue
ENV GOPROXY=${goproxyValue}
ENV SKOPEO_DEPS="libgpgme-dev libassuan-dev libbtrfs-dev libdevmapper-dev pkg-config"
Expand Down