docs: deprecate redis-based caching #9441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narqo
reviewed
Sep 27, 2024
Comment on lines
4828
to
4831
| {{< admonition type="caution" >}} | ||
| Starting with Mimir 2.14, Redis-based caching is deprecated. | ||
| It will be removed in a future release. | ||
| {{< /admonition >}} |
There was a problem hiding this comment.
Update discussed with @56quarters, and it seems that we don't plan to touch anything in the code. Deprecating with only mentioning it in the release notes, and the docs, works for me. We can do that in 2.14 👍
2.14 is planned to be release in 1+ week, with the rc.0 today. I'm not sure, I would rush in marking everything about redis in the code in the release branch as deprecated to support this statement. Can we deprecate it in 2.15?
There was a problem hiding this comment.
We want to deprecated it in 2.14 to give people as much time to migrate as possible.
56quarters
added a commit
that referenced
this pull request
Sep 27, 2024
Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
4 tasks
56quarters
added a commit
that referenced
this pull request
Sep 27, 2024
Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
that referenced
this pull request
Sep 27, 2024
Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
that referenced
this pull request
Sep 27, 2024
* Mark Redis cache backend options as deprecated Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Update CHANGELOG.md --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
approved these changes
Sep 27, 2024
narqo
pushed a commit
that referenced
this pull request
Sep 27, 2024
* Mark Redis cache backend options as deprecated * Update CHANGELOG.md Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d435e78) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
narqo
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Mark Redis cache backend options as deprecated * Update CHANGELOG.md Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d435e78) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
narqo
added a commit
that referenced
this pull request
Oct 9, 2024
* Mark Redis cache backend options as deprecated (#9453) * Mark Redis cache backend options as deprecated * Update CHANGELOG.md Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d435e78) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * update version Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * fixup! update version * update changelog Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR marks the experimental support for Redis-based caching as deprecated.
Which issue(s) this PR fixes or relates to
Fixes https://github.com/grafana/mimir-squad/issues/2414
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.