Mark Redis cache backend options as deprecated #9453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/deprecate-redis-options
branch
from
e13da68
to
f84ba38
Compare
narqo
approved these changes
Sep 27, 2024
Sure, I'll add a changelog entry. This PR was originally opened against the release branch but I'll change to |
Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/deprecate-redis-options
branch
from
f84ba38
to
2bace0f
Compare
56quarters
commented
Sep 27, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9453-to-release-2.14 origin/release-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d435e78bf54c3ee12c14490334114cbc3ce4aaec
# Push it to GitHub
git push --set-upstream origin backport-9453-to-release-2.14
git switch main
# Remove the local backport branch
git branch -D backport-9453-to-release-2.14Then, create a pull request where the |
narqo
pushed a commit
that referenced
this pull request
Sep 27, 2024
* Mark Redis cache backend options as deprecated * Update CHANGELOG.md Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d435e78) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
4 tasks
narqo
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Mark Redis cache backend options as deprecated * Update CHANGELOG.md Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d435e78) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
narqo
added a commit
that referenced
this pull request
Oct 9, 2024
* Mark Redis cache backend options as deprecated (#9453) * Mark Redis cache backend options as deprecated * Update CHANGELOG.md Part of grafana/mimir-squad#2414 Related #9441 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d435e78) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * update version Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * fixup! update version * update changelog Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes or relates to
Part of https://github.com/grafana/mimir-squad/issues/2414
Related #9441
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.