Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add structure to Task init #1035

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Add structure to Task init #1035

merged 3 commits into from
Aug 5, 2024

Conversation

vachillo
Copy link
Member

@vachillo vachillo commented Jul 31, 2024 •
edited
Loading

Describe your changes

  • adds structure parameter to Task init, and updates add_parent/child methods to add the task to the structure if it exists.

Issue ticket number and link

improves syntax: #896

@vachillo vachillo force-pushed the structure_task branch 2 times, most recently from 2d4502c to 725862a Compare July 31, 2024 19:04
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
griptape/tasks/actions_subtask.py 75.00% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@vachillo vachillo marked this pull request as ready for review August 2, 2024 19:22
collindutter
collindutter requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, can you please update the changelog and show the syntax somewhere in the docs?

griptape/tasks/base_task.py Outdated Show resolved Hide resolved
griptape/tasks/base_task.py Outdated Show resolved Hide resolved
collindutter
collindutter previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I want to get @dylanholmes eyes on it before merging since he was doing some work around here too.

dylanholmes
dylanholmes reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Just a couple of minor comments

griptape/structures/pipeline.py Outdated Show resolved Hide resolved
griptape/structures/structure.py Outdated Show resolved Hide resolved
griptape/tasks/base_task.py Outdated Show resolved Hide resolved
griptape/tasks/base_task.py Outdated Show resolved Hide resolved
tests/unit/structures/test_workflow.py Outdated Show resolved Hide resolved
collindutter
collindutter reviewed Aug 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
griptape/structures/structure.py Outdated Show resolved Hide resolved
tests/unit/structures/test_workflow.py Show resolved Hide resolved
dylanholmes
dylanholmes previously approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Just one optional suggestion

griptape/structures/structure.py Show resolved Hide resolved
griptape/tasks/base_task.py Outdated Show resolved Hide resolved
collindutter
collindutter approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@vachillo vachillo merged commit 7ed58cc into dev Aug 5, 2024
14 checks passed
@vachillo vachillo deleted the structure_task branch August 5, 2024 19:11
@collindutter collindutter mentioned this pull request Aug 7, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collindutter collindutter collindutter approved these changes

@dylanholmes dylanholmes Awaiting requested review from dylanholmes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vachillo @dylanholmes @collindutter