Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Adding To Structure For Tool(kit)Task #1047

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

collindutter
Copy link
Member

Describe your changes

Syntax introduced in #1035 was not working for ToolTask and ToolkitTask since they override __attrs_post_init__.

Issue ticket number and link

NA

Copy link
Member

@vachillo vachillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these the only places we need the super call?

@collindutter
Copy link
Member Author

Yes, already confirmed.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@collindutter collindutter merged commit 5d12f95 into dev Aug 7, 2024
14 checks passed
@collindutter collindutter deleted the fix/task-init branch August 7, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants