Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/event lock #1104

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Hotfix/event lock #1104

merged 1 commit into from
Aug 26, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Aug 26, 2024

Describe your changes

Fixed

  • Ensure thread safety when publishing events by adding a thread lock to batch operations in BaseEventListenerDriver.

Issue ticket number and link

Fixes mangled streaming events when using Skatepark/Structure Runtime.


📚 Documentation preview 📚: https://griptape--1104.org.readthedocs.build//1104/

@collindutter collindutter changed the base branch from dev to main August 26, 2024 17:55
@collindutter collindutter marked this pull request as ready for review August 26, 2024 18:03
@collindutter collindutter marked this pull request as draft August 26, 2024 18:04
@collindutter collindutter marked this pull request as ready for review August 26, 2024 18:05
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, to make sure no one is blocked and the solution seems reasonable, but threading is hard and I was worried about this.

Were you able to reproduce the issue? Does this fix consistently prevent the issue?

@collindutter
Copy link
Member Author

@dylanholmes yes I was able to reproduce and this fixes it.

@collindutter collindutter merged commit ad500c1 into main Aug 26, 2024
13 checks passed
@collindutter collindutter deleted the hotfix/event-lock branch August 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants