Have EventListener flush batch #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
fix/event-flush
branch
2 times, most recently
from
3b35ca4
to
9e8d650
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
fix/event-flush
branch
2 times, most recently
from
dd39c2a
to
d8940f9
Compare
collindutter
force-pushed
the
fix/event-flush
branch
3 times, most recently
from
a5de0e3
to
33a00d8
Compare
vachillo
previously approved these changes
Oct 11, 2024
vachillo
reviewed
Oct 11, 2024
collindutter
force-pushed
the
fix/event-flush
branch
from
9782a3f
to
f794eb1
Compare
vachillo
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added
BaseEventListener.flush_events()to flush events from an Event Listener.Changed
BaseEventListener.publish_eventflushargument. UseBaseEventListener.flush_events()instead.BaseEventListenerno longer requires a thread lock for batching events.Fixed
FinishStructureRunEvent.Issue ticket number and link
Closes #1244