Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New year changes #300

Merged
merged 71 commits into from
Dec 30, 2022
Merged

New year changes #300

merged 71 commits into from
Dec 30, 2022

Conversation

Mikejmnez
Copy link
Collaborator

@Mikejmnez Mikejmnez commented Dec 30, 2022

This PR addresses issues #285 , #291 and #299. In particular:

  • Drop no longer an argument (in llc_rearrange.LLC_Transformation.arctic_crown). As a result, the new od.grid of the resulting transformed dataset always has inner and outer as grid_coords.
  • Adds API for llc_rearrange and associated functions and classes.
  • updates history for 0.3.1.
  • deleted find_cs_sn from ospy.utils. local_to_latlon is replaced by llc_local_to_lat_lon within llc_rearrange. This new function can rotate all vector fields and has a grid consistent with a staggered c-grid.
  • viewer_to_range can now take all arguments from poseidon viewer. Included tests for this.
  • xesfm is no longer pinned.
  • updates binder environment: xarray and python are no longer pinned.

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #300 (0a76507) into main (5663338) will increase coverage by 0.49%.
The diff coverage is 92.18%.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   95.25%   95.74%   +0.49%     
==========================================
  Files           9        9              
  Lines        3898     3928      +30     
  Branches      833      850      +17     
==========================================
+ Hits         3713     3761      +48     
+ Misses        116       97      -19     
- Partials       69       70       +1     
Flag Coverage Δ
unittests 95.74% <92.18%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/compute.py 98.81% <ø> (+1.07%) ⬆️
oceanspy/subsample.py 98.04% <ø> (ø)
oceanspy/llc_rearrange.py 88.60% <92.00%> (+0.19%) ⬆️
oceanspy/utils.py 86.86% <92.85%> (+4.43%) ⬆️
oceanspy/_oceandataset.py 97.12% <0.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant