Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: attachment list layout #580

Merged
merged 2 commits into from
Jun 16, 2022
Merged

refactor: attachment list layout #580

merged 2 commits into from
Jun 16, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 16, 2022 •
edited
Loading

What type of PR is this?

/kind improvement
/milestone 1.6.x

What this PR does / why we need it:

  1. 之前的布局没有适配多设备或者超分屏的情况。
  2. 由于固定了单个附件项的高度，所以会导致图片变形。
  3. 使用的 background 属性来显示图片，会导致图片失效或者无法显示的时候显示空白。

此 PR 采用 TailwindCSS + @tailwindcss/aspect-ratio 的方案固定长宽比。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2159

Screenshots:

Before:

image

image

After:

image

image

Special notes for your reviewer:

/cc @halo-dev/sig-halo-admin

Does this PR introduce a user-facing change?

None

@ruibaby
refactor: attachment list layout
3cee985 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG June 16, 2022 05:40
@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 16, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 1.6.x milestone Jun 16, 2022
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 16, 2022
@ruibaby
chore: revert pnpm-locl.yaml
a68e716 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby requested a review from cetr June 16, 2022 05:46
JohnNiang
JohnNiang reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
guqing
guqing reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit b85a89b into halo-dev:master Jun 16, 2022
@ruibaby ruibaby deleted the refactor/attachment-list branch June 16, 2022 07:07
@ruibaby ruibaby mentioned this pull request Jun 26, 2022
Closed
f2c-ci-robot bot pushed a commit to halo-dev/halo that referenced this pull request Oct 12, 2022
@ruibaby
release: 1.6.0 (#2542)
de684ff 
#### What type of PR is this?


#### What this PR does / why we need it:

发布 1.6.0

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo 

```markdown
## Features

- SMTP 添加 STARTTLS 的设置支持。 #1861 halo-dev/console#552 @ntdgy @wangxiaoerYah
- 为邮件通知模板添加更多的可用参数，`email`、`status`、`createTime`、`authorUrl`。 #2095 @Yhcrown @iRoZhi
- 后台附件设置中添加 `去除图片 EXIF 信息` 的选项。 #2168 halo-dev/console#554 @SladeGranger @eziosudo @52lemon6
- 后台文章标签管理支持清理未使用标签。 halo-dev/console#587 @ruibaby
- 重构后台的友情链接管理页面，现在支持拖动排序以及分组管理。 halo-dev/console#574 #2105 @Camsyn @daifiyum @gungnir479

## Improvements

- 优化文章编辑时间更新的逻辑，目前更改为仅在修改文章标题或者内容时才更新。 #2195 @wxyShine @ListenV
- 修改后台管理页面为直接渲染而不是重定向，以更好地兼容反向代理。 #2259 @viticis
- 后台在构建时提供 gzip 压缩的资源。 halo-dev/console#547 @2211898719
- 后台主题设置界面顶部提供了保存设置的按钮。 halo-dev/console#549 @Aanko
- 修改后台页面的 lang 属性，由 `zh-cmn-Hans` 改为 `cmn-Han`，`zh-cmn-Hans` 已废弃。 halo-dev/console#576 @wordlesswind
- 优化后台附件库列表以及选择附件弹框的布局。 halo-dev/console#580 @ruibaby
- 修改后台底部的 `Power by Halo` 为 `Powered by Halo`。 halo-dev/console#597 @liaocp666
- 优化后台日志管理设置公开/隐藏状态的方式。 halo-dev/console#610 @zjy4fun @manction
- 优化后台在个人资料中设置头像的逻辑，现在无需再提交个人资料表单。 halo-dev/console#619 @wxyShine
- 优化后台图库批量从附件添加时，按照选择顺序倒序排列，即最先选择的图片在最前面。 halo-dev/console#631 @zjy4fun @zyy247796143

## Bug Fixes

- 修复文章详情页 `meta_description` 为空的问题。 #2282 @guqing @ruibaby
- 修复批量删除外部云存储的时候，因为文件不存在导致的删除失败问题。 #2317 @JustinLiang522 @129duckflew
- 修复了七牛云存储附件无法上传非图片文件的问题。 #2331 @AirboZH @hexWars
- 修复未审核评论回复会发送邮件提醒的问题。 #2340 @AirboZH @cetr
- 修复在单个分类所属文章页面页面变量中无法获取子分类中文章的问题。 #2405 @JustinLiang522 @HugeLeaf
- 修复管理员资料表单中邮件地址的字符数限制。 halo-dev/console#571 @Yhcrown
- 修复了无法设置日志、相册、链接页标题和每页显示条数的问题。 halo-dev/console#601 @JustinLiang522 @manction

## Dependencies

- Docker 镜像的基础镜像使用 Eclipse Temurin 镜像替代 AdoptOpenJDK。 #2120 @wordlesswind
```

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@guqing guqing guqing left review comments

@LIlGG LIlGG Awaiting requested review from LIlGG

@cetr cetr Awaiting requested review from cetr

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
1.6.x
Development

Successfully merging this pull request may close these issues.

重构管理端附件管理/附件选择/图库管理的文件排列方式
3 participants
@ruibaby @JohnNiang @guqing