Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: batch add to photos in order of image selection #631

Merged
merged 3 commits into from Oct 10, 2022
Merged

perf: batch add to photos in order of image selection #631

merged 3 commits into from Oct 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2022 •
edited by ghost
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

优化后台图库批量添加图片的排序方式

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2487

Screenshots:

动画

Special notes for your reviewer:

  1. 添加了徽标用于展示添加图片的顺序，参考：https://1x.antdv.com/components/badge-cn/#API
  2. 按照图片添加顺序进行排序

Does this PR introduce a user-facing change?

所有页面-图库-选择附件界面添加了徽标，用于展示添加图片的顺序

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 29, 2022

@zjy4fun: The label(s) kind/optimization cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind optimization

What this PR does / why we need it:

优化后台图库批量添加图片的排序方式

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2487

Screenshots:

动画

Special notes for your reviewer:

  1. 添加了徽标用于展示添加图片的顺序，参考：https://1x.antdv.com/components/badge-cn/#API
  2. 按照图片添加顺序进行排序

Does this PR introduce a user-facing change?

所有页面-图库-选择附件界面添加了徽标，用于展示添加图片的顺序

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 29, 2022
@vercel
Copy link

vercel bot commented Sep 29, 2022

@zjy4fun is attempting to deploy a commit to the halo-dev Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
halo-admin-ui ❌ Failed (Inspect) Oct 10, 2022 at 8:28AM (UTC)

@JohnNiang
Copy link
Member

/assign @halo-dev/sig-halo-console

@JohnNiang
Copy link
Member

/cc @halo-dev/sig-halo-console

@ghost ghost closed this Oct 10, 2022
@guqing
Copy link
Member

guqing commented Oct 10, 2022

/reopen 不用关闭，你可以修改之后直接在这个分支推送。

@guqing guqing reopened this Oct 10, 2022
@ghost
Copy link
Author

ghost commented Oct 10, 2022

刚刚又提交了一下，使用索引展示序号更加方便（感谢@ruibaby）
如果不需要序号的话，也可以直接删除掉，这样看来我只需要加一个reverse就可以了 😹

@ghost ghost requested review from ruibaby and removed request for JohnNiang, LIlGG, guqing and lan-yonghui October 10, 2022 06:14
@ruibaby
Copy link
Member

ruibaby commented Oct 10, 2022

如果不需要序号的话，也可以直接删除掉，这样看来我只需要加一个reverse就可以了 😹

我认为这个 PR 先不要添加这个序号好一点，因为这个 PR 的重点是修改添加到图库的顺序。而 AttachmentSelectModal.vue 这个组件在其他地方也有用到，也会同时修改了其他地方的表现。

@ruibaby
Copy link
Member

ruibaby commented Oct 10, 2022

/retitle perf: batch add to photos in order of image selection

@f2c-ci-robot f2c-ci-robot bot changed the title feat: sort uploaded images perf: batch add to photos in order of image selection Oct 10, 2022
@ruibaby
Copy link
Member

ruibaby commented Oct 10, 2022

/kind improvement
/milestone 1.6.x

@f2c-ci-robot f2c-ci-robot bot added this to the 1.6.x milestone Oct 10, 2022
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 10, 2022
ruibaby
ruibaby reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Cool!

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@ruibaby
Copy link
Member

ruibaby commented Oct 10, 2022

/cherrypick release-1.6

@halo-dev-bot
Copy link

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guqing
guqing reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit e21ef82 into halo-dev:master Oct 10, 2022
@halo-dev-bot halo-dev-bot mentioned this pull request Oct 10, 2022
Merged
@halo-dev-bot
Copy link

@ruibaby: new pull request created: #637

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby mentioned this pull request Oct 10, 2022
Closed
3 tasks
f2c-ci-robot bot pushed a commit to halo-dev/halo that referenced this pull request Oct 12, 2022
@ruibaby
release: 1.6.0 (#2542)
de684ff 
#### What type of PR is this?


#### What this PR does / why we need it:

发布 1.6.0

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo 

```markdown
## Features

- SMTP 添加 STARTTLS 的设置支持。 #1861 halo-dev/console#552 @ntdgy @wangxiaoerYah
- 为邮件通知模板添加更多的可用参数，`email`、`status`、`createTime`、`authorUrl`。 #2095 @Yhcrown @iRoZhi
- 后台附件设置中添加 `去除图片 EXIF 信息` 的选项。 #2168 halo-dev/console#554 @SladeGranger @eziosudo @52lemon6
- 后台文章标签管理支持清理未使用标签。 halo-dev/console#587 @ruibaby
- 重构后台的友情链接管理页面，现在支持拖动排序以及分组管理。 halo-dev/console#574 #2105 @Camsyn @daifiyum @gungnir479

## Improvements

- 优化文章编辑时间更新的逻辑，目前更改为仅在修改文章标题或者内容时才更新。 #2195 @wxyShine @ListenV
- 修改后台管理页面为直接渲染而不是重定向，以更好地兼容反向代理。 #2259 @viticis
- 后台在构建时提供 gzip 压缩的资源。 halo-dev/console#547 @2211898719
- 后台主题设置界面顶部提供了保存设置的按钮。 halo-dev/console#549 @Aanko
- 修改后台页面的 lang 属性，由 `zh-cmn-Hans` 改为 `cmn-Han`，`zh-cmn-Hans` 已废弃。 halo-dev/console#576 @wordlesswind
- 优化后台附件库列表以及选择附件弹框的布局。 halo-dev/console#580 @ruibaby
- 修改后台底部的 `Power by Halo` 为 `Powered by Halo`。 halo-dev/console#597 @liaocp666
- 优化后台日志管理设置公开/隐藏状态的方式。 halo-dev/console#610 @zjy4fun @manction
- 优化后台在个人资料中设置头像的逻辑，现在无需再提交个人资料表单。 halo-dev/console#619 @wxyShine
- 优化后台图库批量从附件添加时，按照选择顺序倒序排列，即最先选择的图片在最前面。 halo-dev/console#631 @zjy4fun @zyy247796143

## Bug Fixes

- 修复文章详情页 `meta_description` 为空的问题。 #2282 @guqing @ruibaby
- 修复批量删除外部云存储的时候，因为文件不存在导致的删除失败问题。 #2317 @JustinLiang522 @129duckflew
- 修复了七牛云存储附件无法上传非图片文件的问题。 #2331 @AirboZH @hexWars
- 修复未审核评论回复会发送邮件提醒的问题。 #2340 @AirboZH @cetr
- 修复在单个分类所属文章页面页面变量中无法获取子分类中文章的问题。 #2405 @JustinLiang522 @HugeLeaf
- 修复管理员资料表单中邮件地址的字符数限制。 halo-dev/console#571 @Yhcrown
- 修复了无法设置日志、相册、链接页标题和每页显示条数的问题。 halo-dev/console#601 @JustinLiang522 @manction

## Dependencies

- Docker 镜像的基础镜像使用 Eclipse Temurin 镜像替代 AdoptOpenJDK。 #2120 @wordlesswind
```

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.6.x
Development

Successfully merging this pull request may close these issues.

图库后台批量添加图片，图片的顺序倒序
4 participants
@JohnNiang @guqing @ruibaby @halo-dev-bot