Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a better error message when a colon is forgotten after a filter name #610

Closed
TomasHubelbauer opened this issue May 22, 2023 · 0 comments
Labels

Comments

@TomasHubelbauer
Copy link
Contributor

I am not sure how complex this might be but I am thinking a nice bit of UX would be to warn and guide the user to add a colon if they forgot to add it after a filter name.

{%- assign module = '' | split '' -%}
                              ^ missing colon

Right now I get this error message:

From unexpected token at "''", line:92, col:9, line:91, col:7

I am imagining something like this:

Expected a colon after filter name "split", line:92, col:9, line:91, col:7

@harttle harttle added the bug label May 23, 2023
github-actions bot pushed a commit that referenced this issue Jun 3, 2023
# [10.8.0](v10.7.1...v10.8.0) (2023-06-03)

### Bug Fixes

* proper error message for filter syntax error, [#610](#610) ([0480d33](0480d33))
* sed invocations to work out of the box on macOS ([#615](#615)) ([87d4cc7](87d4cc7))

### Features

* Add support for the Jekyll sample filter ([#612](#612)) ([ba8b842](ba8b842))
* introduce a matrix with latest Ubuntu and macOS to test the build on macOS as well ([82ba548](82ba548)), closes [#615](#615)
* precise line/col for tokenization Error, [#613](#613) ([e347e60](e347e60))
@harttle harttle closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants