fix: sed invocations to work out of the box on macOS #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fixes make the sed invocations run on macOS but I am not sure if they will break the GNU sed invocations in return…
|
From the GitHub Actions workflow: This is what I was worried about, my changes made this portable for BSD |
The sed command line was difficult (impossible?) to be made portable so I just added macOS conditions.
|
Alright I just added macOS specific branches to the shell scripts and I call |
harttle
approved these changes
May 29, 2023
It seems that this will not work because I keep getting "sedi: command not found".
|
Yes, but I’m not sure why alias not working. Bash function is also good for
me.
Thank you for improving this!
|
This seems to work on my local so let's see if it runs in the CI on GitHub.
Not sure why VS Code went with 4.
TomasHubelbauer
added a commit
to TomasHubelbauer/liquidjs
that referenced
this pull request
May 29, 2023
…macOS as well Once harttle#615 is merged, the build script should work on macOS just as well as it does on Ubuntu and with this GitHub Actions matrix we can keep ensuring that it continues to work as it should.
TomasHubelbauer
added a commit
to TomasHubelbauer/liquidjs
that referenced
this pull request
May 29, 2023
…ld on macOS as well Once harttle#615 is merged, the build script should work on macOS just as well as it does on Ubuntu and with this GitHub Actions matrix we can keep ensuring that it continues to work as it should.
harttle
requested changes
May 30, 2023
I am curious if Ubuntu will handle the newline…
harttle
pushed a commit
that referenced
this pull request
Jun 3, 2023
…ld on macOS as well Once #615 is merged, the build script should work on macOS just as well as it does on Ubuntu and with this GitHub Actions matrix we can keep ensuring that it continues to work as it should.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2023
# [10.8.0](v10.7.1...v10.8.0) (2023-06-03) ### Bug Fixes * proper error message for filter syntax error, [#610](#610) ([0480d33](0480d33)) * sed invocations to work out of the box on macOS ([#615](#615)) ([87d4cc7](87d4cc7)) ### Features * Add support for the Jekyll sample filter ([#612](#612)) ([ba8b842](ba8b842)) * introduce a matrix with latest Ubuntu and macOS to test the build on macOS as well ([82ba548](82ba548)), closes [#615](#615) * precise line/col for tokenization Error, [#613](#613) ([e347e60](e347e60))
|
🎉 This PR is included in version 10.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TomasHubelbauer
added a commit
to TomasHubelbauer/liquidjs
that referenced
this pull request
Jun 4, 2023
* fix: sed invocations to work out of the box on macOS These fixes make the sed invocations run on macOS but I am not sure if they will break the GNU sed invocations in return… * fix: add macOS branches to the shell scripts The sed command line was difficult (impossible?) to be made portable so I just added macOS conditions. * Prototype the solution using an alias It seems that this will not work because I keep getting "sedi: command not found". * fix: use a Bash function instead of an alias to run sed portably This seems to work on my local so let's see if it runs in the CI on GitHub. * fix: use 2 spaces like the original scripts did Not sure why VS Code went with 4. * fix: use sedi for the build-changelog `1i\` part as well I am curious if Ubuntu will handle the newline…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes make the sed invocations run on macOS but I am not sure if they will break the GNU sed invocations in return… I am hoping the GitHub Actions workflow will pass and config this is now portable between macOS and Ubuntu (what GitHub Actions is using).