-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AcceptedErrorCodes from MirrorNodeClient - GET_ACCOUNTS_BY_ID_ENDPOINT #1366
Remove AcceptedErrorCodes from MirrorNodeClient - GET_ACCOUNTS_BY_ID_ENDPOINT #1366
Conversation
bf27860
to
64f4f3e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
+ Coverage 77.31% 78.46% +1.15%
==========================================
Files 32 19 -13
Lines 2561 2039 -522
Branches 531 435 -96
==========================================
- Hits 1980 1600 -380
+ Misses 414 307 -107
+ Partials 167 132 -35
☔ View full report in Codecov by Sentry. |
…NDPOINT, so it does not return null, but instead throws the corresponding error and the methods that consume that endpoint handle the errors as they see fit. Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
64f4f3e
to
3b91760
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@AlfredoG87 should rebase this so we can get it in |
closed in favor of this one: #1649 |
Description:
Refactored code around MirrorNodeClient calls to GET_ACCOUNTS_BY_ID_ENDPOINT so it does not return null, but instead throws the corresponding error and the methods that consume that endpoint handle the errors as they see fit.
Related issue(s):
#1276
Fixes
Notes for reviewer:
Checklist