Removed 400 AcceptedErrorCodes from MirrorNodeClient for GET_ACCOUNTS_BY_ID_ENDPOINT path #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath, added UT to verify that errors are being thrown for both 400 and 500 error status codes Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
2 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
AlfredoG87
requested review from
ebadiere,
lukelee-sl and
a team
as code owners
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
=======================================
Coverage 77.43% 77.43%
=======================================
Files 36 36
Lines 2761 2761
Branches 560 560
=======================================
Hits 2138 2138
Misses 447 447
Partials 176 176
☔ View full report in Codecov by Sentry. |
Nana-EC
approved these changes
Aug 21, 2023
Yes there are already some UTs that cover those scenarios |
AlfredoG87
deleted the
1276-refactor-GetAccountsById-remove-accepted-code-2
branch
mshakeg
pushed a commit
to mshakeg/hedera-json-rpc-relay
that referenced
this pull request
Oct 18, 2023
…_BY_ID_ENDPOINT path (hashgraph#1651) removed 400 from acceptedErrorCodes for GET_ACCOUNTS_BY_ID_ENDPOINT path, added UT to verify that errors are being thrown for both 400 and 500 error status codes Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed 400 from acceptedErrorCodes for GET_ACCOUNTS_BY_ID_ENDPOINT path, added UT to verify that errors are being thrown for both 400 and 500 error status codes
Related issue(s): #1276
Fixes #
Notes for reviewer:
This replaces PR 1649
And PR 1366
Checklist