-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated to deploy the contract using a websocket provider. #2332
Conversation
Signed-off-by: ebadiere <ebadiere@gmail.com>
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: Updated to deploy the contract using a websocket provider. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/ws-server/tests/acceptance/estimateGas.spec.ts Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * Update packages/ws-server/tests/acceptance/estimateGas.spec.ts Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * feat: Merged and fixed to deploy using WebSocketProvider. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed .only Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Updated to wait for account to be propagated to the mirror node. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
feat: Updated to deploy the contract using a websocket provider. (#2332) * feat: Updated to deploy the contract using a websocket provider. * Update packages/ws-server/tests/acceptance/estimateGas.spec.ts * Update packages/ws-server/tests/acceptance/estimateGas.spec.ts * feat: Merged and fixed to deploy using WebSocketProvider. * fix: Removed .only * fix: Updated to wait for account to be propagated to the mirror node. --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Cannot reproduce. Updated test to use the websocket provider to deploy the contract.
Related issue(s):
Fixes #2331