Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated to deploy the contract using a websocket provider. #2332

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

ebadiere
Copy link
Collaborator

Cannot reproduce. Updated test to use the websocket provider to deploy the contract.

Related issue(s):

Fixes #2331

Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere added the bug Something isn't working label Apr 11, 2024
@ebadiere ebadiere added this to the 0.46.0 milestone Apr 11, 2024
@ebadiere ebadiere self-assigned this Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Tests

    1 files    35 suites   3s ⏱️
194 tests 193 ✔️ 1 💤 0
197 runs  196 ✔️ 1 💤 0

Results for commit 05caa22.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Acceptance Tests

  15 files  263 suites   16m 48s ⏱️
588 tests 571 ✔️ 4 💤 13
887 runs  868 ✔️ 4 💤 15

Results for commit 05caa22.

♻️ This comment has been updated with latest results.

ebadiere and others added 2 commits April 11, 2024 17:39
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
quiet-node
quiet-node previously approved these changes Apr 12, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlfredoG87
AlfredoG87 previously approved these changes Apr 14, 2024
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere dismissed stale reviews from AlfredoG87 and quiet-node via 45c5b87 April 15, 2024 15:29
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere ebadiere merged commit 4b1cf98 into main Apr 15, 2024
27 of 28 checks passed
@ebadiere ebadiere deleted the 2331-deploy-using-websocketProvider branch April 15, 2024 22:29
AlfredoG87 pushed a commit that referenced this pull request Apr 16, 2024
* feat: Updated to deploy the contract using a websocket provider.

Signed-off-by: ebadiere <ebadiere@gmail.com>

* Update packages/ws-server/tests/acceptance/estimateGas.spec.ts

Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>

* Update packages/ws-server/tests/acceptance/estimateGas.spec.ts

Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>

* feat: Merged and fixed to deploy using WebSocketProvider.

Signed-off-by: ebadiere <ebadiere@gmail.com>

* fix: Removed .only

Signed-off-by: ebadiere <ebadiere@gmail.com>

* fix: Updated to wait for account to be propagated to the mirror node.

Signed-off-by: ebadiere <ebadiere@gmail.com>

---------

Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87 AlfredoG87 mentioned this pull request Apr 16, 2024
2 tasks
AlfredoG87 added a commit that referenced this pull request Apr 16, 2024
feat: Updated to deploy the contract using a websocket provider. (#2332)

* feat: Updated to deploy the contract using a websocket provider.



* Update packages/ws-server/tests/acceptance/estimateGas.spec.ts




* Update packages/ws-server/tests/acceptance/estimateGas.spec.ts




* feat: Merged and fixed to deploy using WebSocketProvider.



* fix: Removed .only



* fix: Updated to wait for account to be propagated to the mirror node.



---------

Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Co-authored-by: Eric Badiere <ebadiere@gmail.com>
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants