Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick 0 46 2332 #2347

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

AlfredoG87
Copy link
Collaborator

Description:
Cherry-pick of #2332 into release 0.46 branch

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* feat: Updated to deploy the contract using a websocket provider.

Signed-off-by: ebadiere <ebadiere@gmail.com>

* Update packages/ws-server/tests/acceptance/estimateGas.spec.ts

Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>

* Update packages/ws-server/tests/acceptance/estimateGas.spec.ts

Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>

* feat: Merged and fixed to deploy using WebSocketProvider.

Signed-off-by: ebadiere <ebadiere@gmail.com>

* fix: Removed .only

Signed-off-by: ebadiere <ebadiere@gmail.com>

* fix: Updated to wait for account to be propagated to the mirror node.

Signed-off-by: ebadiere <ebadiere@gmail.com>

---------

Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87 AlfredoG87 marked this pull request as ready for review April 16, 2024 01:28
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

Tests

    1 files    35 suites   3s ⏱️
194 tests 193 ✔️ 1 💤 0
197 runs  196 ✔️ 1 💤 0

Results for commit 4d750e9.

Copy link

Acceptance Tests

  13 files  238 suites   16m 30s ⏱️
561 tests 544 ✔️ 4 💤 13
775 runs  750 ✔️ 4 💤 21

Results for commit 4d750e9.

@AlfredoG87 AlfredoG87 merged commit c588248 into release/0.46 Apr 16, 2024
25 of 28 checks passed
@AlfredoG87 AlfredoG87 deleted the cherry-pick-0-46-2332 branch April 16, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants