Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dashboards to be Grafana Cloud compatible #2485

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Sep 5, 2021

Description:

  • Add cluster drop down to relevant dashboards with a default of all
  • Add a datasource drop down to relevant dashboards
  • Add an alerts graph by name over time to AlertManager graph
  • Add log graph and messages to Traefik dashboard
  • Bump chart dependencies and image tags
  • Change deprecated policy/v1beta1 to policy/v1
  • Fix chart install directions in README
  • Fix monitor status logs not showing the same errors as metrics
  • Fix various issues with the dashboards
  • Remove InhibitLogAlertWhenHighPublishErrors alert

Related issue(s):

Fixes #2427

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added enhancement Type: New feature P2 process Build or test related tasks labels Sep 5, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.40.0 milestone Sep 5, 2021
@steven-sheehy steven-sheehy requested a review from a team September 5, 2021 00:46
@steven-sheehy steven-sheehy self-assigned this Sep 5, 2021
@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #2485 (307ba5f) into main (e975816) will increase coverage by 0.38%.
The diff coverage is n/a.

❗ Current head 307ba5f differs from pull request most recent head 322900c. Consider uploading reports for the commit 322900c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2485      +/-   ##
============================================
+ Coverage     91.57%   91.95%   +0.38%     
+ Complexity     2536     1955     -581     
============================================
  Files           420      348      -72     
  Lines         11598    10219    -1379     
  Branches       1018      908     -110     
============================================
- Hits          10621     9397    -1224     
+ Misses          645      528     -117     
+ Partials        332      294      -38     
Impacted Files Coverage Δ
.../importer/parser/record/entity/EntityListener.java 42.85% <0.00%> (-42.86%) ⬇️
.../mirror/monitor/subscribe/grpc/GrpcSubscriber.java
...hedera/mirror/monitor/publish/PublishResponse.java
...nitor/subscribe/rest/RestSubscriberProperties.java
...ra/mirror/monitor/subscribe/SubscribeResponse.java
...nsaction/token/TokenFreezeTransactionSupplier.java
...tion/account/AccountCreateTransactionSupplier.java
...java/com/hedera/mirror/monitor/ScenarioStatus.java
...nsaction/token/TokenDeleteTransactionSupplier.java
.../java/com/hedera/mirror/monitor/HederaNetwork.java
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e975816...322900c. Read the comment docs.

@@ -317,7 +317,6 @@ traefik:
additionalArguments:
- "--accesslog=true"
- "--entrypoints.websecure.http.tls=true"
- "--metrics.prometheus=true"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now enabled by default

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification requested on helm upgrade instruction update

charts/README.md Show resolved Hide resolved
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 91b004a into main Sep 7, 2021
@steven-sheehy steven-sheehy deleted the grafana-cloud branch September 7, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P2 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana Cloud compatibility
3 participants