Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token reject transaction #351

Merged

Conversation

MiroslavGatsanoga
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga MiroslavGatsanoga requested review from a team as code owners May 13, 2024 15:27
@MiroslavGatsanoga MiroslavGatsanoga requested review from kimbor and mgoelswirlds and removed request for a team May 13, 2024 15:27
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Would be nice to see comments word-wrap at column 80, but that's a nitpick.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For 0.52 release changes

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@Nana-EC Nana-EC merged commit 42b61af into hashgraph:hip-904-proto-updates May 16, 2024
1 check passed
jsync-swirlds pushed a commit that referenced this pull request Jun 5, 2024
MiroslavGatsanoga added a commit to LimeChain/hedera-protobufs that referenced this pull request Jun 6, 2024
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Neeharika-Sompalli pushed a commit that referenced this pull request Jun 27, 2024
* feat: add token reject transaction (#351)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

* feat: add TokenRejectTransactionBody to transaction_body proto (#354)

Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>

* feat: maxAutoAssociations updates for contract transactions (#359)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

* chore: add status code tokenreject

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

* chore: add empty-reference status code tokenreject

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

---------

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Co-authored-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
* feat: add token reject transaction (#351)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

* feat: add TokenRejectTransactionBody to transaction_body proto (#354)

Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>

* feat: maxAutoAssociations updates for contract transactions (#359)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

* chore: add status code tokenreject

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

* chore: add empty-reference status code tokenreject

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

---------

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Co-authored-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants