-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add token reject transaction #351
Merged
Nana-EC
merged 3 commits into
hashgraph:hip-904-proto-updates
from
LimeChain:hip-904-token-reject
May 16, 2024
Merged
feat: add token reject transaction #351
Nana-EC
merged 3 commits into
hashgraph:hip-904-proto-updates
from
LimeChain:hip-904-token-reject
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
MiroslavGatsanoga
requested review from
kimbor and
mgoelswirlds
and removed request for
a team
May 13, 2024 15:27
jsync-swirlds
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Would be nice to see comments word-wrap at column 80, but that's a nitpick.
Neeharika-Sompalli
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! For 0.52
release changes
Nana-EC
approved these changes
May 13, 2024
2 tasks
MrValioBg
reviewed
May 14, 2024
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
jsync-swirlds
pushed a commit
that referenced
this pull request
Jun 5, 2024
MiroslavGatsanoga
added a commit
to LimeChain/hedera-protobufs
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
jsync-swirlds
pushed a commit
that referenced
this pull request
Jun 24, 2024
Neeharika-Sompalli
pushed a commit
that referenced
this pull request
Jun 27, 2024
* feat: add token reject transaction (#351) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> * feat: add TokenRejectTransactionBody to transaction_body proto (#354) Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> * feat: maxAutoAssociations updates for contract transactions (#359) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> * chore: add status code tokenreject Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> * chore: add empty-reference status code tokenreject Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> --------- Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Co-authored-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add token reject transaction (#351) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> * feat: add TokenRejectTransactionBody to transaction_body proto (#354) Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> * feat: maxAutoAssociations updates for contract transactions (#359) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> * chore: add status code tokenreject Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> * chore: add empty-reference status code tokenreject Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> --------- Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Co-authored-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist