Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP 904 proto updates for token reject #367

Conversation

MiroslavGatsanoga
Copy link
Contributor

@MiroslavGatsanoga MiroslavGatsanoga commented Jun 6, 2024

Description:

Adding protobuf updates related to TokenReject transaction implementation planned for 0.52.

Notes for reviewer:

Merge this PR after hashgraph/hedera-services#13685, otherwise the build in Services develop branch will fail.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga MiroslavGatsanoga force-pushed the hip-904-token-reject-and-pending-state-proto-updates branch 2 times, most recently from aa67273 to 93f8cf1 Compare June 6, 2024 12:55
…raph#354)

Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
@MiroslavGatsanoga MiroslavGatsanoga force-pushed the hip-904-token-reject-and-pending-state-proto-updates branch from 93f8cf1 to dfcf89b Compare June 6, 2024 12:56
MiroslavGatsanoga and others added 2 commits June 7, 2024 15:21
…h#359)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@MiroslavGatsanoga MiroslavGatsanoga force-pushed the hip-904-token-reject-and-pending-state-proto-updates branch from eddff2b to 5953d62 Compare June 7, 2024 12:21
@MiroslavGatsanoga MiroslavGatsanoga changed the title HIP 904 proto updates for token reject and pending state HIP 904 proto updates for token reject Jun 7, 2024
jsync-swirlds
jsync-swirlds previously approved these changes Jun 7, 2024
jsync-swirlds
jsync-swirlds previously approved these changes Jun 11, 2024
steven-sheehy
steven-sheehy previously approved these changes Jun 14, 2024
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

edwin-greene
edwin-greene previously approved these changes Jun 14, 2024
Copy link

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jsync-swirlds
jsync-swirlds previously approved these changes Jun 17, 2024
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
@Neeharika-Sompalli Neeharika-Sompalli merged commit 58f5711 into hashgraph:main Jun 27, 2024
1 check passed
netopyr added a commit that referenced this pull request Jul 18, 2024
* main: (21 commits)
  feat: 13135 Added PlatformState protobuf representation (#349)
  feat: Change AddressBookService package to proto (#386)
  feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380)
  HIP 904 proto updates for token reject (#367)
  chore: Updated codeowners to include devops-ci (#384)
  feat: remove node_get_info.proto (#378)
  fixed INVALID_GOSSIP_CA_CERTIFICATE (#375)
  fix: Fixing single-letter mismatch to expectations (#373)
  feat: Update specification text for address book service (#346)
  feat: Add more response codes for Dynamic Address Book Phase 2 (#370)
  feat: maxAutoAssociations updates for contract transactions (#359)
  Added more response codes for Dynamic Address Book Phase 2 (#364)
  feat: Add back Dynamic Address Book Phase 2 protobufs change (#361)
  feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358)
  feat: added NodeGetInfoResponse to response.proto (#355)
  feat: HIP-904 maxAutoAssociations updates (#348)
  chore: added consensus data protobuf (#350)
  Added NodeGetInfo (#347)
  feat: Dynamic Address Book Phase 2 protobufs changes (#344)
  feat: define event protobufs (#338)
  ...

# Conflicts:
#	services/basic_types.proto
#	services/schedulable_transaction_body.proto
#	services/token_service.proto
#	services/transaction_body.proto
#	services/transaction_receipt.proto
netopyr added a commit that referenced this pull request Jul 18, 2024
* main: (21 commits)
  feat: 13135 Added PlatformState protobuf representation (#349)
  feat: Change AddressBookService package to proto (#386)
  feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380)
  HIP 904 proto updates for token reject (#367)
  chore: Updated codeowners to include devops-ci (#384)
  feat: remove node_get_info.proto (#378)
  fixed INVALID_GOSSIP_CA_CERTIFICATE (#375)
  fix: Fixing single-letter mismatch to expectations (#373)
  feat: Update specification text for address book service (#346)
  feat: Add more response codes for Dynamic Address Book Phase 2 (#370)
  feat: maxAutoAssociations updates for contract transactions (#359)
  Added more response codes for Dynamic Address Book Phase 2 (#364)
  feat: Add back Dynamic Address Book Phase 2 protobufs change (#361)
  feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358)
  feat: added NodeGetInfoResponse to response.proto (#355)
  feat: HIP-904 maxAutoAssociations updates (#348)
  chore: added consensus data protobuf (#350)
  Added NodeGetInfo (#347)
  feat: Dynamic Address Book Phase 2 protobufs changes (#344)
  feat: define event protobufs (#338)
  ...
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
* feat: add token reject transaction (#351)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

* feat: add TokenRejectTransactionBody to transaction_body proto (#354)

Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>

* feat: maxAutoAssociations updates for contract transactions (#359)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>

* chore: add status code tokenreject

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

* chore: add empty-reference status code tokenreject

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

---------

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Co-authored-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants