status argument for data.aws_db_cluster_snapshot and data.aws_db_snapshot

[AliAllomani]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16266

Release note for CHANGELOG:

data-source/aws_db_cluster_snapshot: Add `status` attribute (#16266)
data-source/aws_db_snapshot: Add `status` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDbSnapshotDataSource_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDbSnapshotDataSource_basic -timeout 120m
=== RUN   TestAccAWSDbSnapshotDataSource_basic
=== PAUSE TestAccAWSDbSnapshotDataSource_basic
=== CONT  TestAccAWSDbSnapshotDataSource_basic
2021/01/03 18:59:52 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 18:59:54 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 18:59:56 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 18:59:57 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 19:00:01 [INFO] Waiting for DB Instance (terraform-20210103175959357600000001) to be available
2021/01/03 19:06:32 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 19:06:35 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 19:06:39 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 19:06:42 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 19:06:44 [INFO] Waiting for DB Instance to be destroyed
--- PASS: TestAccAWSDbSnapshotDataSource_basic (643.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       647.092s
...

$ make testacc TESTARGS='-run=TestAccAWSDbSnapshotDataSource_withStatus'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDbSnapshotDataSource_withStatus -timeout 120m
=== RUN   TestAccAWSDbSnapshotDataSource_withStatus
=== PAUSE TestAccAWSDbSnapshotDataSource_withStatus
=== CONT  TestAccAWSDbSnapshotDataSource_withStatus
2021/01/03 20:20:44 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:20:48 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:20:50 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:20:52 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:20:54 [INFO] Waiting for DB Instance (terraform-20210103192053480600000001) to be available
2021/01/03 20:32:20 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:32:23 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:32:28 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:32:31 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:32:36 [WARN] Got error running Terraform: 
Error: Your query returned no results. Please change your search criteria and try again.


2021/01/03 20:32:36 [INFO] AWS Auth provider used: "EnvProvider"
2021/01/03 20:32:39 [INFO] Waiting for DB Instance to be destroyed
--- PASS: TestAccAWSDbSnapshotDataSource_withStatus (946.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       950.085s

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[github-actions]

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.