Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job: ensure that job is running #389

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

rodrigol-chan
Copy link
Contributor

Refs #1. It's sometimes handy to use the UI to stop jobs e.g. during a maintenance event. In this specific case, the provider should check if the job is no longer running and resubmit it. I'm open to suggestions on how to approach this better.

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 13, 2023

CLA assistant check
All committers have signed the CLA.

@rodrigol-chan rodrigol-chan marked this pull request as ready for review October 13, 2023 14:52
@rodrigol-chan
Copy link
Contributor Author

@lgfa29 Sorry for the ping, but is there interest in this? We would really like to solve the "ensure job is running" problem.

@lgfa29
Copy link
Contributor

lgfa29 commented Nov 25, 2023

Hi @rodrigol-chan 👋

Apologies for the delay in review the PR. We're wrapping work for Nomad 1.7, which has kept us busy for the past weeks. I will try to review this some time next week.

Thanks for raising it!

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rodrigol-chan, and apologies again for the delay here.

I think the changes look good, but I do worry about this breaking backwards compatibility in case someone is relying on the existing behaviour.

I added a new flag called rerun_if_dead to allow for this new behaviour to be opt-in but I couldn't push the change to your branch 😅

Since this PR is atomic enough I will merge it as-is and then open a follow-up PR for the new attribute.

Thank you again for the contribution!

@lgfa29 lgfa29 merged commit a81b5f7 into hashicorp:main Dec 15, 2023
1 check passed
lgfa29 added a commit that referenced this pull request Dec 15, 2023
@bertptrs bertptrs deleted the rzl/check-job-status branch April 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants