Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job: add rerun_if_dead argument #407

Merged
merged 2 commits into from
Dec 19, 2023
Merged

job: add rerun_if_dead argument #407

merged 2 commits into from
Dec 19, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 15, 2023

Follow-up work from #389 (review) to introduce a new argument called rerun_if_dead to allow users to opt-in to the new behaviour.

Add the `rerun_if_dead` argument to force a job to run again on apply if
it's currently marked as `dead`.
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could know if changing the default behavior to this would actually be disruptive to anyone, but short of that, this looks like a nice new option!

@lgfa29
Copy link
Contributor Author

lgfa29 commented Dec 19, 2023

We're trying to be more strict with semver on the provider, so I think a change in the default behavour would need to be considered a breaking change.

We can revisit this base on user feedback.

@lgfa29 lgfa29 merged commit e1f9758 into main Dec 19, 2023
3 checks passed
@lgfa29 lgfa29 deleted the f-job-rerun-if-dead branch December 19, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants