Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Ember 5 deprecations: filterBy, mapBy, auto location #25546

Merged
merged 8 commits into from
Feb 21, 2024
Merged

UI: Ember 5 deprecations: filterBy, mapBy, auto location #25546

merged 8 commits into from
Feb 21, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Feb 20, 2024 •
edited
Loading

This PR updates the usage of filterBy and mapBy which were are both deprecated for EmberData 5.0 (no docs for it, but the error message is below)

The mapBy method on the class RecordArray is deprecated. Use the native array method map instead. [deprecation id: ember-data:deprecate-array-like] This will be removed in ember-data 5.0.

findBy is still valid for Mirage, so we do have a few more instances when you find within the UI directory.

This PR also removes the only known reference to auto location which is also deprecated

  • Enterprise tests pass locally

@hashishaw hashishaw added this to the 1.17.0-rc milestone Feb 20, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 20, 2024
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

kiannaquach
kiannaquach approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tackling this, chelsea! i only had one minor suggestion but everything looks good!

hashishaw and others added 3 commits February 21, 2024 12:34
@hashishaw @kiannaquach
Update ui/app/adapters/secret-engine.js
c7ca91c 
remove zeroAddress === true check

Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>
@hashishaw @kiannaquach
Update ui/app/components/wizard/features-selection.js
bddbb76 
Remove feature.selected === true check

Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>
@hashishaw
Merge branch 'main' into ui/VAULT-24262/ember-deprecations-filter-map
7902df0
@hashishaw hashishaw enabled auto-merge (squash) February 21, 2024 18:35
@hashishaw hashishaw merged commit aa5d9f7 into main Feb 21, 2024
26 checks passed
@hashishaw hashishaw deleted the ui/VAULT-24262/ember-deprecations-filter-map branch February 21, 2024 18:45
@hashishaw hashishaw mentioned this pull request May 6, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiannaquach kiannaquach kiannaquach approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Milestone
1.17.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @kiannaquach