UI: upgrade Ember to 5.4 #26708
Merged
UI: upgrade Ember to 5.4 #26708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
hashishaw
commented
May 3, 2024
| @@ -68,6 +68,9 @@ module.exports = { | |||
| // test files | |||
| files: ['tests/**/*-test.{js,ts}'], | |||
| extends: ['plugin:qunit/recommended'], | |||
| rules: { | |||
| 'qunit/require-expect': 'off', | |||
There was a problem hiding this comment.
this rule would have made us remove assert.expect in places where it really does help ensure that certain assertions get called (eg in mirage server requests). So I've turned it off and we can revisit in the future if we want to update our tests and turn it on. https://github.com/platinumazure/eslint-plugin-qunit/blob/main/docs/rules/require-expect.md
hashishaw
commented
May 3, 2024
| @@ -10,7 +10,7 @@ export function initialize() { | |||
| registerDeprecationHandler((message, options, next) => { | |||
| // filter deprecations that are scheduled to be removed in a specific version | |||
| // when upgrading or addressing deprecation warnings be sure to update this or remove if not needed | |||
| if (options?.until.includes('5.0')) { | |||
| if (options?.until.includes('5.0') && options?.for === 'ember-data') { | |||
There was a problem hiding this comment.
Now that we're on Ember 5, we only want to turn of EmberData 5 deprecations
1 task
|
Build Results: |
Monkeychip
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Ember to 5.4 but keeps EmberData at 4.12. As part of the upgrade, a number of other dependencies (ember-power-select, ember-basic-dropdown, ember-concurrency) also needed to be updated and so there are a number of changes as a result of those upgrades as well.
Some changes to be aware of:
Ember Concurrency
The format of tasks has changed, and it looks like the
@taskdecorator is no longer preferred. There is also now support for async methods passed into task (rather than generator functions withyield). The upgrade docs are unhelpful, but I'd recommend revisiting their docs to see the most recent patterns.In addition to the task format, an extra config step is required for concurrency to work within engines.
Ember Power Select
The library updated the test helpers so that some come from
ember-power-select/test-supportand others come fromember-power-select/test-support/helpers😒I added an
ariaLabelattribute to our search-select component, as well as fallbacks, so that our usage of the component is as compliant as possible. Please be aware that the component requires one ofariaLabel,label, oridmoving forward.Deprecations
The following is an incomplete list of PR's that handled deprecated features being removed in Ember 5: