-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: upgrade Ember to 5.4 #26708
Merged
Merged
UI: upgrade Ember to 5.4 #26708
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a69eb92
update to ember 5.4
hashishaw fb3c46d
upgrade ember-a11y-testing
hashishaw 21d1e08
update ember-power-select
hashishaw 1e25496
Remove extended basic-dropdown/trigger
hashishaw 6023ccd
keep ember-data on 4.12.2
hashishaw 14b5d78
do required changes for upgrade to ember-concurrency v4
hashishaw 0b43c9c
bump ember-template-lint-plugin-prettier to fix lint issues
hashishaw ffaae49
globally disable lint rule qunit/require-expect in tests
hashishaw da59513
update ember-cli-page-object version to 2
hashishaw e7dcdf2
run lint:js:fix
hashishaw 9a44c08
only typeInSearch, clickTrigger come from ember-power-select/test-sup…
hashishaw 409a67e
Add ariaLabel to search-select component
hashishaw 5ff13ea
Silence ember-data 5 deprecations only
hashishaw 62fa2ae
Merge branch 'main' into ui/VAULT-26131/upgrade-ember-to-5.4
hashishaw 8df9bfa
remove unused test selector
hashishaw b1ed908
ensure ember-concurrency is correctly loaded in pki and replication e…
hashishaw 370e99e
update ember version in readme
hashishaw 835c432
update deprecation filter
hashishaw e4db9b6
fix aws role test and shared test
hashishaw 06fde1b
fix accessibility error on search-select: ARIA input fields must have…
hashishaw 15c1ebf
Require ariaLabel on search select
hashishaw e258719
Merge branch 'main' into ui/VAULT-26131/upgrade-ember-to-5.4
hashishaw 6e39200
fix get-credentials-card test
hashishaw a394207
Merge branch 'main' into ui/VAULT-26131/upgrade-ember-to-5.4
hashishaw 52dc6a2
Add changelog
hashishaw 4a568e2
Merge branch 'main' into ui/VAULT-26131/upgrade-ember-to-5.4
hashishaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,13 @@ | ||
# unconventional js | ||
/blueprints/*/files/ | ||
/vendor/ | ||
|
||
# compiled output | ||
/dist/ | ||
/tmp/ | ||
|
||
# dependencies | ||
/bower_components/ | ||
/node_modules/ | ||
|
||
# misc | ||
/coverage/ | ||
!.* | ||
.eslintcache | ||
.lint-todo/ | ||
.*/ | ||
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
/bower.json.ember-try | ||
/npm-shrinkwrap.json.ember-try | ||
/package.json.ember-try | ||
/package-lock.json.ember-try | ||
/yarn.lock.ember-try |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"ignore_dirs": ["tmp", "dist"] | ||
"ignore_dirs": ["dist"] | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ export function initialize() { | |
registerDeprecationHandler((message, options, next) => { | ||
// filter deprecations that are scheduled to be removed in a specific version | ||
// when upgrading or addressing deprecation warnings be sure to update this or remove if not needed | ||
if (options?.until.includes('5.0')) { | ||
if (options?.until.includes('5.0') && options?.for === 'ember-data') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now that we're on Ember 5, we only want to turn of EmberData 5 deprecations |
||
return; | ||
} | ||
next(message, options); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,5 @@ | |
<div class="page-container"> | ||
{{outlet}} | ||
</div> | ||
<BasicDropdownWormhole /> | ||
</Sidebar::Frame> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this rule would have made us remove
assert.expect
in places where it really does help ensure that certain assertions get called (eg in mirage server requests). So I've turned it off and we can revisit in the future if we want to update our tests and turn it on. https://github.com/platinumazure/eslint-plugin-qunit/blob/main/docs/rules/require-expect.md