Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP draft - Scaling the Network with Governance & Hedera #480

Merged
merged 31 commits into from
Oct 7, 2022
Merged

HIP draft - Scaling the Network with Governance & Hedera #480

merged 31 commits into from
Oct 7, 2022

Conversation

jamesmeikle
Copy link
Contributor

@jamesmeikle jamesmeikle commented Sep 13, 2022

This is a HIP proposal addressing our main concerns with HIP-70. This is building on the great work on fixing some of the structural issues by the core devs lead by @abhay (hashc0de).

Our concerns are not with the structural changes (specially not the choice of a full-featured LNS to replace console, nor is it with moving to a general purpose L1) but largely around governance, transparency and centralisation. To illustrate we have chosen another DLT technology to show an alternative way. However, we propose a formal review with some independent oversight (see Governance section).

Rendered view: https://github.com/leogaggl/HIP/blob/main/00XY-scaling-helium-transparently.md

PR on behalf of Author(s): @leogaggl, @gregscullard, @pathornteng, @jamesmeikle, @tonysmith55, @nodlRob

leogaggl and others added 29 commits March 9, 2022 14:25
Added myself as an author, let me know if this is appropriate or not - I'm just here to help, I’m happy to conference call to talk through the changes.
-Fixed a bunch of spelling and typo errors - might have added some more, hope not!
-Changed several sentences to be concise, you may want to check the spelling again, I've been at this a while.
-Added roles and subgroups to improvements under summary it is mentioned further through but not up there where it should have been
-Updated motivation wording to include statements from Tony Smith from 3rd March 2022 community zoom meeting with Helium reprehensive, also to recognise existing work
-Updated Stakeholders removed a title to keep with formatting of HIP
-Added how improvement will be achieved to first line of the detailed explanation, note this will mean the proposal is the create the Terms of Reference using the details as the minizine baseline rather then make the proposal the TOR.
-Updated recommendation to include makers and consumers rather than just operators (following Tony Smith's words as for mentioned).
-Removed part about contracts, not sure what you mean but I’m not legal so if it’s something on that…
-We may want to discuss the definition of an independent chair!
-Removed "and remaining committee members" from decision on conflict of interest, the TOR will have to describe what occurs if the chair has a conflict of interest.
-Added quorum statement, feel free to change and look at proxy use.
-Updated titles to use the role words instead of expected to be more consistent with a TOR and the improvements mentioned in summary.
-Added to chair and member roles some nominal common TOR ones
-Updated Drawbacks statement, no I didn’t add one about my conversation with our friendly discord community 😉
-Added to Rationale on reduced confidence statement as per a few comments from Helium discord.
-Added to the todo for out of scope and an unresolved question. Let me know if you can answer the unresolved question as IoT has a lot of inherent security issues.
Gathered feedback #1 and my feedback on the HIP
Bullet points incorrect
@Buckshot22
Copy link

Well written proposal. My personal opinion is that the governance and transparency issues are the most important.

I feel that combining these with the L1 choice may cloud those important factors and I suggest the two be separated. I feel that the ship may have sailed on the L1 and it is something that is desperately needed and shouldn't be held up.

Great work!

@leogaggl
Copy link
Contributor

Thanks for contributing @Buckshot22 !

We have had this conversation between the authors. And this might well be what ends up happening.

However, to achieve the decentralisation part of the design goals we felt it was important to show that there are alternatives to what has been put forward in HIP-70 that could achieve this from the outset in a scalable manner.

The other reason for including this is that the governance structure that was chosen by our DLT is also something worth considering for the Helium Foundation.

@vincenzospaghetti
Copy link
Contributor

I am also working on a governance proposal and will make that available for the community to read when I am done! This is separate from the L1 change, and is remaining separate, as @Buckshot22 suggested.

@jamiew jamiew added the draft label Sep 14, 2022
@jamiew jamiew changed the title Hip scaling helium transparently HIP draft - Scaling Helium Transparently Sep 14, 2022
@leogaggl
Copy link
Contributor

leogaggl commented Sep 17, 2022

I am also working on a governance proposal and will make that available for the community to read when I am done! This is separate from the L1 change, and is remaining separate, as @Buckshot22 suggested.

Thanks @vincenzospaghetti - that is great to hear that there is finally some work being done on the governance side. We had the same response after the April Helium Foundation Community Call (https://vimeo.com/542796385) where Scott told us that work was underway already.

From the meeting notes (https://docs.google.com/document/d/1bMm2alBigBj3detA775Dn0Gz9UM5XczAeK9vnjBB3l0/):

sc0tt: announced last night that the current Lorawan Committee wouldn’t be issuing more rulings. Foundation is working on a solid framework for voting and a standardized committee framework. foundation is building a directory to provide transparency among all. High priority is formalizing governance.

However despite multiple follow-ups and offers to collaborate we have never had a response from the Foundation as to the progress of this.

That was the core reason to write this into this HIP proposal in the first place as HIP-70 has highlighted the shortcomings in all of those areas.

  1. Transparency
  2. Governance
  3. Decentralised oracles

The L1 to illustrate that this can be done from the start rather than by "hope" as it has been expressed by Foundation members and core devs in AMA's and Discord.

@gregscullard
Copy link

Unsure how to contribute some code to this HIP, so here's a link to a public repo containing a POC for the proposed architecture on Hedera: https://github.com/gregscullard/he2-poc

There will likely be updates over time, but this is in a good enough shape to share.

@gregscullard
Copy link

Recorded a video of the POC here (from 3:50 onwards)
https://www.youtube.com/watch?v=H-zomi_ywFY&t=1s

@leogaggl
Copy link
Contributor

Unsure how to contribute some code to this HIP, so here's a link to a public repo containing a POC for the proposed architecture on Hedera: https://github.com/gregscullard/he2-poc

There will likely be updates over time, but this is in good enough shape to share.

Thanks, @gregscullard - great example! Not sure either as I have never seen any code attached to HIP. Just checked the HIP-70 and I can't see any code there.

Correct typos previously identified. Have NOT changed diagrams per my notes, only MarkDown.
New PoC data reporting diagram - correct "Decentralized Oracales"
@vincenzospaghetti
Copy link
Contributor

Hi @leogaggl - although there is no code attached to HIP 70 there is a dedicated development team. Can you answer in your HIP who would implement this?

@nodlRob
Copy link

nodlRob commented Sep 22, 2022

I represent the HBAR Foundation (Hedera's commercialisation partner), and we would be very happy to work with Nova Labs to implement this migration to Hedera. If Nova Labs cannot do this then it would be developed by a combination of Hedera development partners funded by the HBar Foundation (as open source) supported by Swirlds Labs and the wider developer ecosystem.

@leogaggl
Copy link
Contributor

Hi @leogaggl - although there is no code attached to HIP 70 there is a dedicated development team. Can you answer in your HIP who would implement this?

Hi @vincenzospaghetti - I think the question is probably contrary to some of the issues we've tried to address in the HIP. The way the selection process for the L1 was done (or more not done) is related to the lack of clear governance and independent oversight from the Helium Foundation. That still needs to be addressed I believe.

But I think Rob's comment above should answer your question anyway. We can incorporate this into the HIP after presenting this at the Helium Community Call next Wednesday.

@leogaggl
Copy link
Contributor

leogaggl commented Sep 23, 2022

Forgot to attach the Community Call agenda: https://docs.google.com/document/d/1bMm2alBigBj3detA775Dn0Gz9UM5XczAeK9vnjBB3l0/

@vincenzospaghetti
Copy link
Contributor

vincenzospaghetti commented Sep 23, 2022

@leogaggl and team - we have you on the agenda to present this HIP in the Community Call this coming Wed. If something changes and you cannot attend or present please let me know.

@hiptron
Copy link
Collaborator

hiptron commented Oct 5, 2022

@leogaggl @gregscullard @pathornteng @jamesmeikle @tonysmith55 hi all, we are discussing this HIP on the Triage Call and think it might be worth splitting this into multiple HIPs to be discussed independently. e.g.

  1. governance HIP (or roll this revisiting Terms of Reference or combine efforts/ @vincenzospaghetti's governance-HIP draft?)
  2. decentralized oracles
  3. Hadera as L1 selection

what do you think? Having pieces distinct makes it easier to respond (and approve) each major piece. Let us know if 2 + 3 together makes sense too

@leogaggl
Copy link
Contributor

leogaggl commented Oct 5, 2022

Thanks @hiptron

As indicated we are happy to discuss any changes to this DRAFT and welcome input.

I already mentioned to @vincenzospaghetti that these calls all happen at between 1-3 AM (depending on where you are) in the morning in Australia. And since most of the team is in Australia and is working during the day that is not a reasonable time.

To your point 1 - this dates back to April and we have been told then that it would be incorporated as a matter of priority then. We have indicated in several emails to Scott and other Helium Foundation team members that we are keen to see some work done. We never had any replies.

As for points 2 & 3 that would really be a discussion including the DLT specialists. The reason the HIP included these three components is that we believe that they are intrinsically linked. I have tried to explain this in the [presentation to the Community Call] (https://vimeo.com/755374521). The following image tries to explain that reasoning ( Slides )
image

If there is a better way to do this we are happy to make changes. Or please feel free to submit any changes to the doc!

@vincenzospaghetti
Copy link
Contributor

Hi @leogaggl - how do you want to move this forward? At this point, if your HIP wants a move to Hedera, it would have to repeal HIP 70. I suggest a separate HIP for this.

If you would like to open a channel in the Helium Official Community to discuss this, we will do that. Still, there are many points here that I think is asking a lot of the community to consider rather than narrowing in on either governance, L1, or oracles. Please advise and we'll move this forward.

@leogaggl
Copy link
Contributor

leogaggl commented Oct 7, 2022

how do you want to move this forward? At this point, if your HIP wants a move to Hedera, it would have to repeal HIP 70. I suggest a separate HIP for this.

I am personally struggling with this split as these things are intrinsically connected. We wouldn't be in this position if governance had been sorted and the Helium Foundation would have ensured some independence and transparency in this selection process and actually asked for alternatives to come forward. Rather than waiting for a HIP to be written on the eve of a vote and then having to "repeal" a HIP.

Of course, we believe using Hedera as the L1 is the better option. Otherwise, we would not have used it as an example (both from an architectural as well as a governance perspective) and gone to the extent of creating a proof-of-concept with it.

However, rather than just doing the same thing as HIP-70 and ignoring any evaluation process our approach was to do a proper transparent evaluation. This could probably be done in a number of ways. Building out a PoC that can simulate the load with alternative options is one example.

We have tried to reach out to the Helium Foundation to find out how this can be achieved. Forcing a fork as has been suggested by @abhay on the Helium Discord as the only option does not seem a healthy outcome from the perspective of the Helium Network.

If you would like to open a channel in the Helium Official Community to discuss this, we will do that. Still, there are many points here that I think is asking a lot of the community to consider rather than narrowing in on either governance, L1, or oracles. Please advise and we'll move this forward.

I am unsure how you want to split Oracles from the L1. How do you want to achieve transparent (ie. on-chain) and decentralised "oracles" without an L1 that is actually capable of doing this?

The reason we ended up with this architecture is that the L1 that was chosen in HIP-70 is not capable of this architecture. In fact, the most recent Solana outage has been used to justify the centralised off-chain oracle architecture.

@abhay
Copy link
Contributor

abhay commented Oct 7, 2022

Hi @leogaggl - how do you want to move this forward? At this point, if your HIP wants a move to Hedera, it would have to repeal HIP 70. I suggest a separate HIP for this.

I disagree actually. it feels like this proposal automatically repeals HIP 70 if the community decides to go with this approach. I'd be okay with this proposal being more explicit about that but it already seems implicit.

We wouldn't be in this position if governance had been sorted and the Helium Foundation would have ensured some independence and transparency in this selection process and actually asked for alternatives to come forward.

This is a bit disingenuous. The idea of a new L1 has been proposed as early as HIP-51. That was back in January of this year.

Forcing a fork as has been suggested by @abhay on the Helium Discord as the only option does not seem a healthy outcome from the perspective of the Helium Network.

It is one of many options but given that there's a community vote on HIP-70 plus several engineers already moving towards a HIP-70 implementation, should that work be ignored?

I'd recommend this draft be finalized and brought to a vote ASAP. Let the proposal stand and be voted upon.

@vincenzospaghetti
Copy link
Contributor

Hi @leogaggl - it looks like there's enough discussion on this regardless of if it is several HIPs or not. I'm going to go ahead and open a channel for you on the server and mark this as HIP 71.

@vincenzospaghetti vincenzospaghetti changed the title HIP draft - Scaling Helium Transparently HIP draft - Scaling the Network with Governance & Hedera Oct 7, 2022
@vincenzospaghetti vincenzospaghetti linked an issue Oct 7, 2022 that may be closed by this pull request
@vincenzospaghetti vincenzospaghetti marked this pull request as ready for review October 7, 2022 19:45
@vincenzospaghetti vincenzospaghetti merged commit 785c108 into helium:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP 71: Scaling the Network with Governance & Hedera
10 participants