-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: determine rust channel from rust-toolchain.toml
#2528
Labels
Comments
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this issue
May 22, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this issue
May 23, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this issue
May 23, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
archseer
pushed a commit
that referenced
this issue
May 23, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. #2528 covers switching back to the upstream when it includes those changes.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this issue
Jun 15, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this issue
Jun 15, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
actions-rs/toolchain
action used in CI can determine which rust channel to use from therust-toolchain.toml
file rather than the explicittoolchain: stable
argument passed currently.It doesn't work perfectly at the moment. There's an upstream PR that will fix the functionality: actions-rs/toolchain#209.
For now we can fork the toolchain action and merge that PR. Eventually we should switch back to the upstream when that PR is merged.
See also:
The text was updated successfully, but these errors were encountered: