Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin rust toolchain version in rust-toolchain file #2513

Conversation

the-mikedavis
Copy link
Member

This is a less verbose alternative to #2512 that uses the rustup rust-toolchain file to pin the version of rust so new releases can't cause CI failures. Ideally actions-rs/toolchain should be able to support rust-toolchain.toml which already exists in this repo but it looks like there are a few PRs that haven't been updated in a while for adding support there. We may want to fork that action under helix-editor and merge it ourselves to make this less hacky.

@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label May 19, 2022
@archseer
Copy link
Member

There's already a rust-toolchain.toml which is now preferred over .rust-toolchain
https://github.com/helix-editor/helix/blob/master/rust-toolchain.toml

@the-mikedavis
Copy link
Member Author

the-mikedavis commented May 21, 2022

I did initially try that but it looks like the rustup version included in the actions runner is too old and it doesn't know about the .toml one, or it's a bug within actions-rs/toolchain: https://github.com/the-mikedavis/helix/runs/6516161434?check_suite_focus=true. It might be workable if we pull in actions-rs/toolchain#209 though

@the-mikedavis
Copy link
Member Author

I'll try out setting up a fork of actions-rs/toolchain. Having both versions of the rust-toolchain file seems hacky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants