improving the file saving procedure #11153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of network file systems, if the server time is ahead of the local system time, then helix could annoy with messages that the file has already been modified by another application.
Now: - origin file is not touched if write is failed - file's metadata copied before write
kirawi
added
C-enhancement
|
I am going to close this since we decided to stick with the approach vim uses instead: #11142 (comment) Thanks for working on this! Hardlinks will be solved by #11340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now helix should use fs' mtime instead of system time, that fixes problems with out-of-sync network filesystems
Use another file to write before replace origin, that gives a little more "good" behavior in case of write failure
Prevent overwrite origin file if origin is changed while write
this change includes #11142