Fix writing hardlinks #11340
Merged
Fix writing hardlinks #11340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
C-bug
pascalkuthe
reviewed
Jul 27, 2024
|
implementation looks good now, there are some build failures in the integration tests tough. Once the tests are ready and passing this should be good to go. Thanks for implementing this. It's good to be more robust here! |
pascalkuthe
added
the
S-waiting-on-review
the-mikedavis
approved these changes
Jul 27, 2024
SofusA
pushed a commit
to SofusA/helix-pull-diagnostics
that referenced
this pull request
Aug 4, 2024
* don't use backup files with hardlinks * check if the inodes remain the same in the test * move funcs to faccess and use AsRawHandle * use a copy as a backup for hardlinks * delete backup after copy
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
* don't use backup files with hardlinks * check if the inodes remain the same in the test * move funcs to faccess and use AsRawHandle * use a copy as a backup for hardlinks * delete backup after copy
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
* don't use backup files with hardlinks * check if the inodes remain the same in the test * move funcs to faccess and use AsRawHandle * use a copy as a backup for hardlinks * delete backup after copy
plul
pushed a commit
to plul/helix
that referenced
this pull request
Oct 13, 2024
* don't use backup files with hardlinks * check if the inodes remain the same in the test * move funcs to faccess and use AsRawHandle * use a copy as a backup for hardlinks * delete backup after copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11279