Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using the format ident Rust feature #1881

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Avoid using the format ident Rust feature #1881

merged 1 commit into from
Mar 30, 2022

Conversation

tranzystorekk
Copy link
Contributor

@tranzystorekk tranzystorekk commented Mar 29, 2022 •
edited
Loading

While this feature is undeniably ergonomic, it mostly inflates the MSRV, which is a problem over at Void Linux where bumping Rust version is a lengthy process.

Checked with cargo-msrv that with these changes the MSRV drops to 1.57

archseer
archseer approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is reasonable 👍🏻

@archseer archseer merged commit f2dd3d4 into helix-editor:master Mar 30, 2022
@tranzystorekk tranzystorekk deleted the rust-msrv branch March 30, 2022 00:09
@sudormrfbin sudormrfbin mentioned this pull request Apr 3, 2022
Closed
@archseer archseer mentioned this pull request Apr 5, 2022
Merged
This was referenced Apr 8, 2022
Closed
Merged
@sudormrfbin sudormrfbin mentioned this pull request Apr 17, 2022
Closed
@pickfire pickfire mentioned this pull request May 16, 2022
Merged
the-mikedavis added a commit to the-mikedavis/helix that referenced this pull request May 22, 2022
@the-mikedavis
check MSRV in CI
962de8c 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change adds a new CI check which uses the cargo-msrv crate to
verify an MSRV version recorded in helix-term's Cargo.toml. When
changing MSRV, we can then edit `helix-term/Cargo.toml`'s
`package.metadata.msrv` key.

The MSRV is set at 1.60.0 for the sake of checkmarks on builds but
ideally we want to support 1.57.0. The PR that closes helix-editor#2460 should
set this MSRV metadata key back to 1.57.0.

Closes helix-editor#2482.
@the-mikedavis the-mikedavis mentioned this pull request May 22, 2022
Closed
the-mikedavis added a commit to the-mikedavis/helix that referenced this pull request May 22, 2022
@the-mikedavis
check MSRV in CI
5074f8e 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change adds a new CI check which uses the cargo-msrv crate to
verify an MSRV version recorded in helix-term's Cargo.toml. When
changing MSRV, we can then edit `helix-term/Cargo.toml`'s
`package.metadata.msrv` key.

The MSRV is set at 1.60.0 for the sake of checkmarks on builds but
ideally we want to support 1.57.0. The PR that fixes the MSRV in helix-editor#2460
should set this MSRV metadata key back to 1.57.0.

Closes helix-editor#2482.
the-mikedavis added a commit to the-mikedavis/helix that referenced this pull request May 22, 2022
@the-mikedavis
check MSRV in CI
c2fae80 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change adds a new CI check which uses the cargo-msrv crate to
verify an MSRV version recorded in helix-term's Cargo.toml. When
changing MSRV, we can then edit `helix-term/Cargo.toml`'s
`package.metadata.msrv` key.

The MSRV is set at 1.60.0 for the sake of checkmarks on builds but
ideally we want to support 1.57.0. The PR that fixes the MSRV in helix-editor#2460
should set this MSRV metadata key back to 1.57.0.

Closes helix-editor#2482.
the-mikedavis added a commit to the-mikedavis/helix that referenced this pull request May 23, 2022
@the-mikedavis
check MSRV in CI
22534ab 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change runs the "Check" step for the pinned version of rust in
the rust-toolchain.toml file as well as the MSRV version in a matrix.
In order to bump the MSRV, we need to edit

    .github/workflows/msrv-rust-toolchain.toml

This commit sets the MSRV as 1.60.0 but a later child commit will
reduce the MSRV back to 1.57.0.

Closes helix-editor#2482.
the-mikedavis added a commit to the-mikedavis/helix that referenced this pull request May 23, 2022
@the-mikedavis
check MSRV in CI
36e2cba 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change runs the "Check" step for the pinned version of rust in
the rust-toolchain.toml file as well as the MSRV version in a matrix.
In order to bump the MSRV, we need to edit

    .github/workflows/msrv-rust-toolchain.toml

This commit sets the MSRV as 1.60.0 but a later child commit will
reduce the MSRV back to 1.57.0.

Closes helix-editor#2482.
the-mikedavis added a commit to the-mikedavis/helix that referenced this pull request May 23, 2022
@the-mikedavis
check MSRV in CI
dbbea9d 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change runs the "Check" step for the pinned version of rust in
the rust-toolchain.toml file as well as the MSRV version in a matrix.
In order to bump the MSRV, we need to edit

    .github/workflows/msrv-rust-toolchain.toml

This commit sets the MSRV as 1.60.0 but a later child commit will
reduce the MSRV back to 1.57.0.

Closes helix-editor#2482.
archseer pushed a commit that referenced this pull request May 23, 2022
@the-mikedavis @archseer
check MSRV in CI
92df5a5 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See #1881.

This change runs the "Check" step for the pinned version of rust in
the rust-toolchain.toml file as well as the MSRV version in a matrix.
In order to bump the MSRV, we need to edit

    .github/workflows/msrv-rust-toolchain.toml

This commit sets the MSRV as 1.60.0 but a later child commit will
reduce the MSRV back to 1.57.0.

Closes #2482.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
@the-mikedavis @mtoohey31
check MSRV in CI
495145d 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change runs the "Check" step for the pinned version of rust in
the rust-toolchain.toml file as well as the MSRV version in a matrix.
In order to bump the MSRV, we need to edit

    .github/workflows/msrv-rust-toolchain.toml

This commit sets the MSRV as 1.60.0 but a later child commit will
reduce the MSRV back to 1.57.0.

Closes helix-editor#2482.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
@the-mikedavis @mtoohey31
check MSRV in CI
f11d009 
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See helix-editor#1881.

This change runs the "Check" step for the pinned version of rust in
the rust-toolchain.toml file as well as the MSRV version in a matrix.
In order to bump the MSRV, we need to edit

    .github/workflows/msrv-rust-toolchain.toml

This commit sets the MSRV as 1.60.0 but a later child commit will
reduce the MSRV back to 1.57.0.

Closes helix-editor#2482.
@the-mikedavis the-mikedavis mentioned this pull request Jun 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tranzystorekk @archseer