check MSRV in CI, lower MSRV to 1.57.0 #2532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
reviewed
May 22, 2022
It's very easy to use new rust features without realizing it since the CI and local development workflows may use the latest rust version. We try to keep some backwards compatibility with rust versions to make packaging easier for some OS-level package-managers like Void Linux's. See helix-editor#1881. This change adds a new CI check which uses the cargo-msrv crate to verify an MSRV version recorded in helix-term's Cargo.toml. When changing MSRV, we can then edit `helix-term/Cargo.toml`'s `package.metadata.msrv` key. The MSRV is set at 1.60.0 for the sake of checkmarks on builds but ideally we want to support 1.57.0. The PR that fixes the MSRV in helix-editor#2460 should set this MSRV metadata key back to 1.57.0. Closes helix-editor#2482.
This line uses the Display trait for io::ErrorKind which was stabilized in Rust 1.60.0. We can set MSRV all the way back to 1.57.0 by replacing it with a pretty-print. Closes helix-editor#2460
the-mikedavis
changed the title
|
Actually I think it's best to do this by using a matrix for the Check job: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very easy to use new rust features without realizing it since
the CI and local development workflows may use the latest rust version.
We try to keep some backwards compatibility with rust versions to make
packaging easier for some OS-level package-managers like Void Linux's.
See #1881.
This change adds a new CI check which uses the cargo-msrv crate to
verify an MSRV version recorded in helix-term's Cargo.toml. When
changing MSRV, we can then edit
helix-term/Cargo.toml'spackage.metadata.msrvkey.The MSRV is set at 1.60.0 for the sake of checkmarks on builds but
ideally we want to support 1.57.0. The PR that fixes the MSRV in #2460
should set this MSRV metadata key back to 1.57.0.
Closes #2482.