-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog notes for 23.10 #8086
Conversation
do we want to wait on the next TS release (and potentially move to 23.9) so we can remove the git dependency? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinks for your effort! I think I would group some stuff a bit differently (see comments). I think we discussed in one of the last changelog PRs to be a bit more permissive with what we categorize as a feature. This is ofcoures subjective/a fuzzy line but I added a couple suggestions for what could be moved
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
9e5ddd3
to
3178bdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits I found
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
b7d75a4
to
5e00eb5
Compare
You mentioned on #8396 (comment) but the plan is no longer to wait on a tree-sitter release, correct? I know TS said there would be a release a week ago, but it still seems like the repo has at least a few weeks' work before that can happen https://github.com/tree-sitter/tree-sitter/labels/CICD |
Yep, unless they release within the next few days we will most likely switch to 0.20.10 for the release and then revert afterwards |
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
No description provided.