Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helix installation instructions #376

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

philipgiuliani
Copy link
Contributor

@philipgiuliani philipgiuliani commented Sep 18, 2023

Adds the helix installation instructions. I am using it myself in Helix and it works like a charm.

Closes #228

pages/installation.md Outdated Show resolved Hide resolved
@scottming
Copy link
Collaborator

scottming commented Sep 18, 2023

Hi, @philipgiuliani I tried this on my mac, it won't works.

Bad language config: unknown field `language-servers`, expected one of `name`, `scope`, `file-types`, `shebangs`, `roots`, `comment-token`, `text-width`, `soft-wrap`, `config`, `auto-format`, `formatter`, `diagnostic-severity`, `grammar`, `injection-regex`, `language-server`, `indent`, `debugger`, `auto-pairs`, `rulers`, `workspace-lsp-roots`
in `language`

Press <ENTER> to continue with default language config

and tried

[language-server.lexical]
command = "/Users/scottming/Code/lexical/_build/dev/package/lexical"

[[language]]
name = "elixir"
language-server = ["lexical"]

[[language]]
name = "heex"
language-server = ["lexical"]
``` too

@philipgiuliani
Copy link
Contributor Author

philipgiuliani commented Sep 18, 2023

Oh sorry, the last Version of Helix has been released on May. I am using the next version, which will be released within September: helix-editor/helix#8086

Unfortunately, there was a breaking change with the last Helix release. Should I document both configurations here, or maybe we should just extend the information that it only works above Helix 23.09?

From the Changelog:

Breaking changes:

  • Support multiple language servers per language (#2507)
    • This is a breaking change to language configuration

@scottming
Copy link
Collaborator

extend the information that it only works above Helix 23.09?

I think adding this is enough.

@scottming
Copy link
Collaborator

Ok, I tried the main branch, and this config works, thanks.

image

@scohen scohen merged commit ee76a0e into lexical-lsp:main Sep 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve installation docs
3 participants