Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rds-postgres] - The Execution Fails when Table name is in camel case #147

Merged
merged 10 commits into from
Feb 13, 2023

Conversation

lucass4
Copy link
Contributor

@lucass4 lucass4 commented Jan 30, 2023

Description

I am submitting this PR to address an issue related to having a table name in camel case.

Scenario

The execution fails due to extra double quotes automatically add to tableNames and foreign keys.

Command:

klepto steal -c .klepto.toml --from="postgres://user:password@db-klepto-test-cluster.cluster-asxxxxxxxsdasdasd.us-east-1.xxxxx.amazonaws.com/dbName?sslmode=disable" --to="postgres://user:password@db-klepto-destination.cluster-asdasdasdasdasdasd.us-east-1.rds.amazonaws.com/dbName?sslmode=disable" **--to-rds** --concurrency=50

Error example:

error=failed to re-create ForeignKey "TableName".TableNames_userID_users_fk: pq: insert or update on table "TableName" violates foreign key constraint "TableNames_userID_users_fk" 

@lucass4
Copy link
Contributor Author

lucass4 commented Feb 9, 2023

Hey @lucasmdrs, if you have some time, could you please check this PR? 🙇‍♂️

@davnnis2003
Copy link

@lucass4 @lucasmdrs hey guys - u do realize that this repo is public right? :D

@lucass4
Copy link
Contributor Author

lucass4 commented Feb 9, 2023

@lucass4 @lucasmdrs hey guys - u do realize that this repo is public right? :D

@davnnis2003 Sorry, I think I am missing the point. what do you mean? I do realize it is a public project and a public repo.

@codecov-commenter
Copy link

Codecov Report

Merging #147 (ac941cd) into master (3d992e3) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   48.22%   48.22%           
=======================================
  Files           8        8           
  Lines         309      309           
=======================================
  Hits          149      149           
  Misses        153      153           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lucasmdrs
Copy link
Contributor

Thank you for the contribution! @lucass4

@lucasmdrs lucasmdrs merged commit 18f1617 into hellofresh:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants