Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rds-postgres] - The Execution Fails when Table name is in camel case #147

Merged
merged 10 commits into from
Feb 13, 2023
Merged

[rds-postgres] - The Execution Fails when Table name is in camel case #147

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
053d2fd
fix: Remove all quotes in table name
lucass4 Jan 26, 2023
97e37ad
fix: Remove all quotes in postgres table name
lucass4 Jan 27, 2023
b0eb315
fix: Small typo in erro msg
lucass4 Jan 27, 2023
0bbf6e6
fix: Remove all quotes in postgres table name
lucass4 Jan 27, 2023
4e13472
fix: Remove all quotes in postgres table name
lucass4 Jan 27, 2023
fed5b8c
fix: Remove all quotes in postgres table name
lucass4 Jan 27, 2023
55a17e7
fix: Remove all quotes in postgres table name
lucass4 Jan 27, 2023
2da4a8d
fix: Remove all quotes in postgres table name
lucass4 Jan 30, 2023
ad9217b
fix: Remove all quotes in postgres table name
lucass4 Jan 30, 2023
ac941cd
fix: Remove all quotes in postgres table name
lucass4 Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Remove all quotes in table name
  • Loading branch information
@lucass4
lucass4 committed Jan 26, 2023
commit 053d2fdc6ac0692082e8cc92abb41fb496e42c1e
13 changes: 9 additions & 4 deletions pkg/dumper/postgres/dumper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"database/sql"
"fmt"
"strconv"
"strings"

"github.com/lib/pq"
log "github.com/sirupsen/logrus"
Expand Down Expand Up @@ -111,9 +112,11 @@ func (d *pgDumper) PreDumpTables(tables []string) error {
if err := rows.Scan(&fk.tableName, &fk.constraintName, &fk.constraintDefinition); err != nil {
return fmt.Errorf("failed to load ForeignKeyInfo: %w", err)
}
query := fmt.Sprintf("ALTER TABLE %s DROP CONSTRAINT %s", strconv.Quote(fk.tableName), strconv.Quote(fk.constraintName))

tableName := strings.ReplaceAll(fk.tableName, "\"", "")
query := fmt.Sprintf("ALTER TABLE %s DROP CONSTRAINT %s", strconv.Quote(tableName), strconv.Quote(fk.constraintName))
if _, err := d.conn.Exec(query); err != nil {
return fmt.Errorf("failed to frop contraint %s.%s: %w", fk.tableName, fk.constraintName, err)
return fmt.Errorf("failed to drop constraint %s.%s: %w", fk.tableName, fk.constraintName, err)
}
d.foreignKeys = append(d.foreignKeys, fk)
}
Expand All @@ -126,7 +129,8 @@ func (d *pgDumper) PostDumpTables(tables []string) error {
if !d.isRDS {
log.Debug("Reenabling triggers")
for _, tbl := range tables {
query := fmt.Sprintf("ALTER TABLE %s ENABLE TRIGGER ALL", strconv.Quote(tbl))
tableName := strings.ReplaceAll(tbl, "\"", "")
query := fmt.Sprintf("ALTER TABLE %s ENABLE TRIGGER ALL", strconv.Quote(tableName))
if _, err := d.conn.Exec(query); err != nil {
return fmt.Errorf("failed to enable triggers for %s: %w", tbl, err)
}
Expand All @@ -136,7 +140,8 @@ func (d *pgDumper) PostDumpTables(tables []string) error {

log.Debug("Recreating foreign keys")
for _, fk := range d.foreignKeys {
query := fmt.Sprintf("ALTER TABLE %s ADD CONSTRAINT %s %s", strconv.Quote(fk.tableName), strconv.Quote(fk.constraintName), fk.constraintDefinition)
tableName := strings.ReplaceAll(fk.tableName, "\"", "")
query := fmt.Sprintf("ALTER TABLE %s ADD CONSTRAINT %s %s", strconv.Quote(tableName), strconv.Quote(fk.constraintName), fk.constraintDefinition)
if _, err := d.conn.Exec(query); err != nil {
return fmt.Errorf("failed to re-create ForeignKey %s.%s: %w", fk.tableName, fk.constraintName, err)
}
Expand Down