Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge #23

Merged
merged 8 commits into from
Sep 18, 2018
Merged

Merge #23

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
22677be
Updated API Endpoint, frequency of update msg
crypto49er Sep 14, 2018
dc6ad43
make sure we dont close the stream until async indicators are done, f…
askmike Sep 16, 2018
ab0d124
[GB] add initial limit & lazyload ticker
askmike Sep 16, 2018
b22afa5
[GB] provide fill information on coinfalcon cancel
askmike Sep 16, 2018
b209aa0
[GB] log all exchange erors
askmike Sep 16, 2018
7d548fb
[GB] catch more cloudfare timeouts with unknown results
askmike Sep 16, 2018
d8b90d7
[GB] minimum order size for doge on kraken, fix #2535
askmike Sep 17, 2018
767f225
manually trigger gekko stream finalize
askmike Sep 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[GB] provide fill information on coinfalcon cancel
  • Loading branch information
@askmike
askmike committed Sep 16, 2018
commit b22afa571582146960532ab3dc3c29cce4de7837
7 changes: 4 additions & 3 deletions exchange/wrappers/coinfalcon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ Trader.prototype.retry = function(method, args) {

// run the failed method again with the same arguments after wait
setTimeout(() => {
console.log('cf retry..');
console.log(args);
method.apply(this, args);
}, wait);
};
Expand Down Expand Up @@ -257,6 +255,7 @@ Trader.prototype.cancelOrder = function(order, callback) {
const args = _.toArray(arguments);

const handle = this.processResponse(this.cancelOrder, args, (err, res) => {

if(err) {
if(err.message.includes('has wrong status.')) {

Expand Down Expand Up @@ -284,7 +283,9 @@ Trader.prototype.cancelOrder = function(order, callback) {
return callback(err);
}

callback(undefined, false);
callback(undefined, false, {
filled: res.data.size_filled
});
});

this.coinfalcon.delete('user/orders/' + order).then(handle.success).catch(handle.failure);
Expand Down