Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #23

Merged
merged 8 commits into from
Sep 18, 2018
Prev Previous commit
Next Next commit
make sure we dont close the stream until async indicators are done, fix
  • Loading branch information
askmike committed Sep 16, 2018
commit dc6ad437268183cbcb209ea8441c0c7b237411d9
1 change: 1 addition & 0 deletions core/gekkoStream.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ Gekko.prototype.finalize = function() {
}

Gekko.prototype.shutdown = function() {
this.end();
async.eachSeries(
this.plugins,
function(c, callback) {
Expand Down
1 change: 0 additions & 1 deletion core/markets/backtest.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ Market.prototype.processCandles = function(err, candles) {
if(this.ended) {
this.closed = true;
this.reader.close();
this.emit('end');
} else {
util.die('Query returned no candles (do you have local data for the specified range?)');
}
Expand Down