-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device name customization on ZHA add devices page #25180
Fix device name customization on ZHA add devices page #25180
Conversation
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge.
* ensure new device exists * clean up dev reg handling * update test * fix tests
…into hive_water_heater * 'dev' of https://github.com/home-assistant/home-assistant: (49 commits) Pin Docker to Debain Stretch (home-assistant#25206) Updated frontend to 20190717.0 Add HmIP-PCBS2, HmIP-PCBS-BAT to Homematic IP Cloud (home-assistant#25201) Simplify cache restore (home-assistant#25186) Only include target temp if has right support flag (home-assistant#25193) Fix issue home-assistant#24495 (home-assistant#25199) Handle somfy expired token (home-assistant#25195) Add login_method config option to fix login issue with RouterOS Version > 6.43 (home-assistant#25194) Add HMIP-FCI / HMIP-FBL / HmIP-BBL (home-assistant#25188) [climate] Tweak evohome migration (home-assistant#25187) Fix device name customization on ZHA add devices page (home-assistant#25180) Upgrade mypy to 0.720, turn on unreachability warnings (home-assistant#25157) Use MockConfigEntry (home-assistant#25190) Add severe weather sensor to Dark Sky (home-assistant#22701) Fix typo in azure-pipelines-ci.yml Raise not ready when no data from API is retrieved (home-assistant#25182) Improve Nuki lock (home-assistant#22888) Delete config.yml (home-assistant#25181) Upgrade luftdaten to 0.6.2 (home-assistant#25177) Upgrade Mastodon.py to 1.4.5 (home-assistant#25176) ... # Conflicts: # homeassistant/components/hive/water_heater.py
Description:
This PR cleans up the usage of the device registry during device adding and removal and addresses #25164
Related issue: fixes #25164
Checklist:
tox
. Your PR cannot be merged unless tests pass