Simplify cache restore #25186
Merged
Simplify cache restore #25186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
reviewed
Jul 16, 2019
|
In that case let's add a comment to the YAML |
|
Great catch! I had not thought about that and it makes total sense! I'll revert the change and add a comment to the YAML for later reference! |
balloob
reviewed
Jul 17, 2019
balloob
approved these changes
Jul 17, 2019
KJonline
pushed a commit
to Rendili/home-assistant
that referenced
this pull request
Jul 17, 2019
…into hive_water_heater * 'dev' of https://github.com/home-assistant/home-assistant: (49 commits) Pin Docker to Debain Stretch (home-assistant#25206) Updated frontend to 20190717.0 Add HmIP-PCBS2, HmIP-PCBS-BAT to Homematic IP Cloud (home-assistant#25201) Simplify cache restore (home-assistant#25186) Only include target temp if has right support flag (home-assistant#25193) Fix issue home-assistant#24495 (home-assistant#25199) Handle somfy expired token (home-assistant#25195) Add login_method config option to fix login issue with RouterOS Version > 6.43 (home-assistant#25194) Add HMIP-FCI / HMIP-FBL / HmIP-BBL (home-assistant#25188) [climate] Tweak evohome migration (home-assistant#25187) Fix device name customization on ZHA add devices page (home-assistant#25180) Upgrade mypy to 0.720, turn on unreachability warnings (home-assistant#25157) Use MockConfigEntry (home-assistant#25190) Add severe weather sensor to Dark Sky (home-assistant#22701) Fix typo in azure-pipelines-ci.yml Raise not ready when no data from API is retrieved (home-assistant#25182) Improve Nuki lock (home-assistant#22888) Delete config.yml (home-assistant#25181) Upgrade luftdaten to 0.6.2 (home-assistant#25177) Upgrade Mastodon.py to 1.4.5 (home-assistant#25176) ... # Conflicts: # homeassistant/components/hive/water_heater.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the second example in this documentation using the
RestoreAndSaveCachetask simplifies things a bit. The Save Cache task will be automatically added as a post build step/task!This is an untested change so please test before merge!