Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 1968 and correct visitor pattern code #1990

Closed
wants to merge 8 commits into from
Closed

fix issue 1968 and correct visitor pattern code #1990

wants to merge 8 commits into from

Conversation

xyllq999
Copy link
Contributor

fix issue 1968 and correct visitor pattern code

Modified issue with visitor mode code, changed different method name to method reload, fixed issue1968.

Pull request description

The main modification of the method in the class is visit, which is accessed only by different parameter types, eliminating some errors and simplifying code writing, in line with the pattern requirements.

@xyllq999
Copy link
Contributor Author

this PR helps for solve #1968

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

ohbus
ohbus suggested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contributions!!

Please address the review comments and possibly eliminate the sonar issues as reported in the comment and make it a spotless PR.

Looking forward to this!

visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java Outdated Show resolved Hide resolved
visitor/src/main/java/com/iluwatar/visitor/Sergeant.java Outdated Show resolved Hide resolved
visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java Outdated Show resolved Hide resolved
visitor/src/main/java/com/iluwatar/visitor/Soldier.java Outdated Show resolved Hide resolved
visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java Outdated Show resolved Hide resolved
visitor/src/main/java/com/iluwatar/visitor/UnitVisitor.java Outdated Show resolved Hide resolved
visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java Outdated Show resolved Hide resolved
visitor/src/test/java/com/iluwatar/visitor/SoldierTest.java Outdated Show resolved Hide resolved
@ohbus ohbus linked an issue Jun 3, 2022 that may be closed by this pull request
Visitor pattern code example violate SOLID #1968
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@xyllq999
Copy link
Contributor Author

@ohbus I have remove all the comment, thanks a lot!

@xyllq999 xyllq999 closed this by deleting the head repository Sep 10, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohbus ohbus ohbus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.

Visitor pattern code example violate SOLID
3 participants
@xyllq999 @ohbus @iluwatar