Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 1968 and correct visitor pattern code #1990

Closed
wants to merge 8 commits into from
Closed

fix issue 1968 and correct visitor pattern code #1990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc8256e
fix issue 1968 and correct visitor pattern code
xyllq999 Apr 23, 2022
ed32c3c
add Javadoc and comments for issue
xyllq999 Apr 24, 2022
36b7b77
add Javadoc and comments for issue
xyllq999 Apr 24, 2022
d5bb722
init fix for issue #1957
xyllq999 May 9, 2022
d77bd0c
remove comments.
xyllq999 Jun 4, 2022
9c679cc
remove useless javadoc.
xyllq999 Jun 4, 2022
63fe8e5
remove useless javadoc.
xyllq999 Jun 4, 2022
3aff130
remove useless javadoc.
xyllq999 Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add Javadoc and comments for issue
  • Loading branch information
@xyllq999
xyllq999 committed Apr 24, 2022
commit 36b7b77c57d33e0a3d09d911ef502c90336c8e9e
2 changes: 1 addition & 1 deletion visitor/src/main/java/com/iluwatar/visitor/Commander.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public Commander(Unit... children) {

/**
* Accept a Visitor.
* @param visitor
* @param visitor An implementation class of Unit.
*/
@Override
public void accept(UnitVisitor visitor) {
Expand Down
6 changes: 3 additions & 3 deletions visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class CommanderVisitor implements UnitVisitor {

/**
* Soldier Visitor method.
* @param soldier
* @param soldier An implementation class of Unit.
*/
@Override
public void visit(Soldier soldier) {
Expand All @@ -43,7 +43,7 @@ public void visit(Soldier soldier) {

/**
* Sergeant Visitor method.
* @param sergeant
* @param sergeant An implementation class of Unit.
*/
@Override
public void visit(Sergeant sergeant) {
Expand All @@ -52,7 +52,7 @@ public void visit(Sergeant sergeant) {

/**
* Commander Visitor method.
* @param commander
* @param commander An implementation class of Unit.
*/
@Override
public void visit(Commander commander) {
Expand Down
2 changes: 1 addition & 1 deletion visitor/src/main/java/com/iluwatar/visitor/Sergeant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public Sergeant(Unit... children) {

/**
* Accept a visitor.
* @param visitor
* @param visitor An implementation class of Unit.
*/
@Override
public void accept(UnitVisitor visitor) {
Expand Down
6 changes: 3 additions & 3 deletions visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class SergeantVisitor implements UnitVisitor {

/**
* Soldier Visitor method.
* @param soldier
* @param soldier An implementation class of Unit.
*/
@Override
public void visit(Soldier soldier) {
Expand All @@ -43,7 +43,7 @@ public void visit(Soldier soldier) {

/**
* Sergeant Visitor method.
* @param sergeant
* @param sergeant An implementation class of Unit.
*/
@Override
public void visit(Sergeant sergeant) {
Expand All @@ -52,7 +52,7 @@ public void visit(Sergeant sergeant) {

/**
* Commander Visitor method.
* @param commander
* @param commander An implementation class of Unit.
*/
@Override
public void visit(Commander commander) {
Expand Down
2 changes: 1 addition & 1 deletion visitor/src/main/java/com/iluwatar/visitor/Soldier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public Soldier(Unit... children) {

/**
* Accept a visitor.
* @param visitor
* @param visitor An implementation class of Unit.
*/
@Override
public void accept(UnitVisitor visitor) {
Expand Down
6 changes: 3 additions & 3 deletions visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class SoldierVisitor implements UnitVisitor {

/**
* Soldier visitor method.
* @param soldier
* @param soldier An implementation class of Unit.
*/
@Override
public void visit(Soldier soldier) {
Expand All @@ -44,7 +44,7 @@ public void visit(Soldier soldier) {

/**
* Sergeant visitor method.
* @param sergeant
* @param sergeant An implementation class of Unit.
*/
@Override
public void visit(Sergeant sergeant) {
Expand All @@ -53,7 +53,7 @@ public void visit(Sergeant sergeant) {

/**
* Commander visitor method.
* @param commander
* @param commander An implementation class of Unit.
*/
@Override
public void visit(Commander commander) {
Expand Down
6 changes: 3 additions & 3 deletions visitor/src/main/java/com/iluwatar/visitor/UnitVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,19 @@ public interface UnitVisitor {

/**
* Soldier visit method.
* @param soldier
* @param soldier An implementation class of Unit.
*/
void visit(Soldier soldier);

/**
* Sergeant visit method.
* @param sergeant
* @param sergeant An implementation class of Unit.
*/
void visit(Sergeant sergeant);

/**
* Commander visit method.
* @param commander
* @param commander An implementation class of Unit.
*/
void visit(Commander commander);

Expand Down